Skip to content

Create codeql.yml workflow #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 29, 2025
Merged

Create codeql.yml workflow #314

merged 10 commits into from
Apr 29, 2025

Conversation

w0rmr1d3r
Copy link
Member

@w0rmr1d3r w0rmr1d3r commented Feb 26, 2025

Description

Create Code Scanning workflow in codeql.yml
Copy-Pasting the config from pycfmodel (sibling repo): https://github.com/Skyscanner/pycfmodel/blob/master/.github/workflows/codeql.yml

Solving low-warning "Note" issues surfaced during the scans.

Checklist

  • I have updated the CHANGELOG.md file accordingly

@w0rmr1d3r w0rmr1d3r self-assigned this Feb 26, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@w0rmr1d3r w0rmr1d3r marked this pull request as ready for review March 3, 2025 14:46
jsoucheiron
jsoucheiron previously approved these changes Apr 24, 2025
Copy link
Member

@jsoucheiron jsoucheiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment that can be ignored.

AliceMEd
AliceMEd previously approved these changes Apr 25, 2025
@w0rmr1d3r w0rmr1d3r dismissed stale reviews from jsoucheiron and AliceMEd via 287702f April 28, 2025 09:40
Copy link
Member

@jsoucheiron jsoucheiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoucheiron jsoucheiron merged commit 3ebf8c5 into master Apr 29, 2025
11 checks passed
@jsoucheiron jsoucheiron deleted the enable-codeql branch April 29, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants