ci: reconcile release workflows with the development repository - #219
Merged
Conversation
These workflows are maintained by hand in two repositories and had drifted in both directions. This brings this repository to the union of the fixes: parsed Gem::Version comparison in release-gem.yml (RubyGems rewrites SemVer prereleases, so raw-string comparison false-negatives on the next prerelease tag), the setup-java v5.6.0 pin in release-maven.yml, and a spacing normalization in release-nuget.yml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SummarySmall, well-scoped CI-only change reconciling release workflows with the development repo. The gem version-comparison fix is correct and the accompanying comments clearly explain the reasoning; Maven/NuGet changes are trivial. No core (Rust/Python/Node) code is touched, so most FFI/CDP/security review categories don't apply here. 🔴 Critical Issues (0)None found. 🟡 Suggestions (1)
📝 Minor / Style (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflows here and in the development repository are maintained by hand and had drifted in both directions. Releases are cut from tags on this repository, so these are the copies that actually run.
This applies the union of both sides' fixes to the three files that differed:
Gem::Versionvalues. RubyGems rewrites a SemVer prerelease (0.3.0-beta.1becomes0.3.0.pre.beta.1), so the current raw-string comparison would abort the next prerelease gem release with a false "versions do not match".actions/setup-java(v5.6.0).The matching change on the development side has already merged, leaving the shared workflow files byte-identical in both repositories.
release-npm.ymlandrelease-pypi.ymlalready matched.🤖 Generated with Claude Code