feat(deps): restore browser-harness in compare extra as a PyPI dep - #26
Closed
wintonzheng wants to merge 2 commits into
Closed
feat(deps): restore browser-harness in compare extra as a PyPI dep#26wintonzheng wants to merge 2 commits into
wintonzheng wants to merge 2 commits into
Conversation
browser-harness is published on PyPI (>=0.1.5), so the compare extra can reference it as a normal requirement instead of the git URL PyPI rejects. It requires Python 3.11+, so a version marker keeps the extra installable on rustwright's older supported Pythons. twine check passes; Requires-Dist contains no URL dependency. Refs: SKY-12273 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K7b2PMrqsT9BJGaF6DFJA2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K7b2PMrqsT9BJGaF6DFJA2
SummaryNarrow, well-motivated metadata change that correctly unblocks 🔴 Critical Issues (1)
🟡 Suggestions (1)
📝 Minor / Style (1)
|
wintonzheng
enabled auto-merge (squash)
July 13, 2026 03:49
auto-merge was automatically disabled
July 13, 2026 20:01
Pull request was closed
suchintan
added a commit
that referenced
this pull request
Jul 14, 2026
Skyvern-AI/rustwright-cloud#26 --------- Co-authored-by: suchintan <3853670+suchintan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore browser-harness in the
compareextra as a normal PyPI requirement (browser-harness>=0.1.5 ; python_version >= '3.11'), replacing the git-URL form removed in #25.Why
The git-URL dependency was removed in #25 because PyPI rejects direct URL dependencies. browser-harness is published on PyPI (https://pypi.org/project/browser-harness/), so the extra can depend on it normally. It requires Python 3.11+ while rustwright supports 3.8+, so the environment marker keeps
pip install rustwright[compare]working on older Pythons (the dep is simply skipped there). No version bump; this rides the next release tag.Testing
Requires-Dist: browser-harness>=0.1.5 ; python_full_version >= '3.11' and extra == 'compare'(no URL deps)Checklist