Skip to content

feat(deps): restore browser-harness in compare extra as a PyPI dep - #26

Closed
wintonzheng wants to merge 2 commits into
mainfrom
shu/sky-12273-browser-harness-pypi
Closed

feat(deps): restore browser-harness in compare extra as a PyPI dep#26
wintonzheng wants to merge 2 commits into
mainfrom
shu/sky-12273-browser-harness-pypi

Conversation

@wintonzheng

Copy link
Copy Markdown
Contributor

What

Restore browser-harness in the compare extra as a normal PyPI requirement (browser-harness>=0.1.5 ; python_version >= '3.11'), replacing the git-URL form removed in #25.

Why

The git-URL dependency was removed in #25 because PyPI rejects direct URL dependencies. browser-harness is published on PyPI (https://pypi.org/project/browser-harness/), so the extra can depend on it normally. It requires Python 3.11+ while rustwright supports 3.8+, so the environment marker keeps pip install rustwright[compare] working on older Pythons (the dep is simply skipped there). No version bump; this rides the next release tag.

Testing

  • twine check PASSED on a locally built maturin sdist
  • Rendered metadata: Requires-Dist: browser-harness>=0.1.5 ; python_full_version >= '3.11' and extra == 'compare' (no URL deps)

Checklist

  • I kept this change focused.
  • I added or updated tests for behavior changes. (n/a: metadata-only)
  • I did not include private credentials, tokens, or internal-only artifacts.

wintonzheng and others added 2 commits July 12, 2026 08:11
browser-harness is published on PyPI (>=0.1.5), so the compare extra can
reference it as a normal requirement instead of the git URL PyPI rejects.
It requires Python 3.11+, so a version marker keeps the extra installable
on rustwright's older supported Pythons.

twine check passes; Requires-Dist contains no URL dependency.

Refs: SKY-12273

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K7b2PMrqsT9BJGaF6DFJA2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K7b2PMrqsT9BJGaF6DFJA2
@github-actions github-actions Bot deleted a comment from claude Bot Jul 12, 2026
@claude

claude Bot commented Jul 12, 2026

Copy link
Copy Markdown

Summary

Narrow, well-motivated metadata change that correctly unblocks pip install rustwright[compare] by replacing an install-from-git comment with a real PyPI dep. One supply-chain confirmation is needed before merging.

🔴 Critical Issues (1)
  • Supply-chain identity check required (pyproject.toml line 34): The old comment pointed to github.com/browser-use/browser-harness. The new dep pulls browser-harness from PyPI with no confirmation that the PyPI package is published by the same browser-use org. Package-name squatting is a real vector, and this PR does not include a link to the PyPI release page showing the maintainer matches (the body links to the project URL but the maintainer field / PyPI publisher is what matters). Before merging, confirm on https://pypi.org/project/browser-harness/ that the "Maintainers" or Trusted Publisher config belongs to the browser-use org that owns the original GitHub repo.
🟡 Suggestions (1)
  • No upper-bound on the dep: >=0.1.5 is fully open-ended. browser-harness is still at 0.x so a <1 cap (>=0.1.5,<1) would be conventional for pre-stable software and prevent a hypothetical incompatible 1.0 from silently entering the compare environment. Low risk today since this is a dev/benchmark extra, but worth doing while the dep is new.
📝 Minor / Style (1)
  • Marker normalization note: The source uses python_version >= '3.11' but the PR description notes the rendered wheel metadata shows python_full_version >= '3.11'. This is maturin/pip normalizing the marker and is functionally equivalent — PEP 508 version ordering applies to both. Just flagging so future maintainers aren't surprised by the discrepancy between pyproject.toml and METADATA.

@wintonzheng
wintonzheng enabled auto-merge (squash) July 13, 2026 03:49
auto-merge was automatically disabled July 13, 2026 20:01

Pull request was closed

suchintan added a commit that referenced this pull request Jul 14, 2026
Skyvern-AI/rustwright-cloud#26

---------

Co-authored-by: suchintan <3853670+suchintan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant