-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add run_with to workflow run webhook response #3851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3){skyvern,integrations,alembic,scripts}/**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
skyvern/**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 63ebfb3 in 1 minute and 7 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. skyvern/forge/sdk/workflow/service.py:2058
- Draft comment:
Addedrun_with=workflow_run.run_withto the webhook response. Ensure that this field is always valid (or has a proper default) and that the corresponding response schema and docs are updated. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_9AwBQv9hyjIopq2I
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
This is not what the user is interested in. They're interested in reporting whether a cache was actually used - not whether the user requested a cache be used |
🔧 This PR adds the
run_withfield to the workflow run webhook response, ensuring that webhook consumers receive complete information about how the workflow was executed.🔍 Detailed Analysis
Key Changes
run_with=workflow_run.run_withto theWorkflowRunResponseobject in theexecute_workflow_webhookfunctionTechnical Implementation
sequenceDiagram participant Client participant WebhookService participant WorkflowRun participant Response Client->>WebhookService: execute_workflow_webhook() WebhookService->>WorkflowRun: Get workflow_run data WorkflowRun-->>WebhookService: workflow_run object WebhookService->>Response: Create WorkflowRunResponse Note over Response: Now includes run_with field Response-->>Client: Complete webhook responseImpact
run_withinformation available in other workflow run endpointsCreated with Palmier
Important
Add
run_withfield toWorkflowRunResponseinservice.pyto include execution method in webhook response.run_withfield toWorkflowRunResponseinexecute_workflow_webhook()inservice.pyto include the execution method in the webhook response.This description was created by
for 63ebfb3. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit