Draft
Conversation
jcfr
reviewed
Jul 11, 2019
Member
There was a problem hiding this comment.
i posted few comments.
It may also worth looking into implementing CLI using approach like this one:
- https://github.com/Slicer/Slicer/blob/master/Base/QTCLI/Testing/PyCLIModule4Test.py
- https://github.com/Slicer/Slicer/blob/master/Base/QTCLI/Testing/PyCLIModule4Test.xml
We could even streamling the parsing of argument using https://github.com/commontk/ctk-cli doing something like this:
from ctk_cli import CLIArgumentParser
def main(args):
[...]
if __name__ == "__main__":
main(CLIArgumentParser().parse_args())similar approach used in https://github.com/DigitalSlideArchive/HistomicsTK/blob/06aba476ea83da672b9ab59cc9b6caa43524cb04/histomicstk/cli/NucleiDetection/NucleiDetection.py
14 tasks
Contributor
Author
Yes, I removed it for now. I might change it later |
Member
|
Rebased against master (as of Dec 21 2021) to include c++ sources of CLI originally contributed in e9602ca but not yet available in the SurfaceToolbox: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding C++ CLIs with functionality. They have not been implemented within Surface Toolbox yet.
I still need to update XML files and extension settings.