BUG: Fix GW_Face::GetEdgeNumber to return -1 if edge is not found#49
Draft
jcfr wants to merge 1 commit intoSlicer:masterfrom
Draft
BUG: Fix GW_Face::GetEdgeNumber to return -1 if edge is not found#49jcfr wants to merge 1 commit intoSlicer:masterfrom
jcfr wants to merge 1 commit intoSlicer:masterfrom
Conversation
Member
Author
|
Following discussion with @lassoan during Slicer hangout of Nov 2nd 2021, we decided not fix this as it could potentially introduce crashes. Further investigations are required. |
This commit fixes the following warning introduced in 3e42453 (ENH: Add SelectByPoints tool to DynamicModeler) /path/to/SurfaceToolbox/DynamicModeler/Logic/FastMarching/gw_core/GW_Face.inl: In member function ‘GW::GW_I32 GW::GW_Face::GetEdgeNumber(const GW::GW_Vertex&, const GW::GW_Vertex&)’: /path/to/SurfaceToolbox/DynamicModeler/Logic/FastMarching/gw_core/GW_Face.inl:359:9: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null] return NULL; ^
jcfr
force-pushed
the
fix-gw-face-get-edge-number-return
branch
from
4a50d15 to
083f223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following warning introduced in
3e42453 (ENH: Add SelectByPoints tool to DynamicModeler)