Open
Conversation
Author
Contributor
|
Thank you for your contribution! I think @jcfr is on vacation. I should be able to look at this later this week, maybe on Friday. In the meantime, it would be great help if you could add a GUI connector for |
yehan0223
force-pushed
the
mesh_alignment
branch
from
d7e2314 to
aa2950d
Compare
Member
Member
I will work with @sjh26 to add this to Slicer. |
jcfr
added a commit
to slicersalt/Slicer
that referenced
this pull request
Apr 7, 2025
…dates This commit updates the Slicer build to backport the MeshAlignment module from the SlicerSALT fork of SlicerSurfaceToolbox. The changes correspond to those proposed in Slicer/SlicerSurfaceToolbox#71, which are still under review and not yet merged upstream. The updated sources are downloaded from the SlicerSALT fork to ensure availability of the latest improvements. List of changes: ``` $ git shortlog e8b8f7093..26715cf15 --no-merges Ye Han (1): [Backport PR-71] ENH: Add MeshAligment Module ```
jcfr
added a commit
to slicersalt/Slicer
that referenced
this pull request
Apr 7, 2025
This commit updates the Slicer build to backport the MeshAlignment module from the SlicerSALT fork of SlicerSurfaceToolbox. The changes correspond to those proposed in Slicer/SlicerSurfaceToolbox#71, which are still under review and not yet merged upstream. The updated sources are downloaded from the SlicerSALT fork to ensure availability of the latest improvements. List of changes: ``` $ git shortlog e8b8f7093..26715cf15 --no-merges Ye Han (1): [Backport PR-71] ENH: Add MeshAligment Module ```
jcfr
added a commit
to slicersalt/Slicer
that referenced
this pull request
Apr 7, 2025
This commit updates SlicerSurfaceToolbox to backport the MeshAlignment module from the SlicerSALT fork. The changes correspond to those proposed in Slicer/SlicerSurfaceToolbox#71, which are still under review and not yet merged upstream. List of changes: ``` $ git shortlog e8b8f7093..26715cf15 --no-merges Ye Han (1): [Backport PR-71] ENH: Add MeshAligment Module ```
jcfr
added a commit
to Kitware/SlicerSALT
that referenced
this pull request
Apr 7, 2025
…dates This commit updates Slicer to include the MeshAlignment module added to the the SlicerSALT fork of SlicerSurfaceToolbox. The changes correspond to those proposed in Slicer/SlicerSurfaceToolbox#71, which are still under review and not yet merged upstream.
yehan0223
force-pushed
the
mesh_alignment
branch
from
e66a8bc to
76d68c7
Compare
jcfr
added a commit
to slicersalt/Slicer
that referenced
this pull request
Apr 9, 2025
This commit updates SlicerSurfaceToolbox to backport the following modules from the SlicerSALT fork: - AverageMesh - MeshDataImprinter - SurfaceDistance - SurfaceFeatureExtractor It also backports improvements associated with the MeshAlignment module. These changes correspond to those proposed in the following pull requests which are still under review and not yet merged upstream: - Slicer/SlicerSurfaceToolbox#71 - Slicer/SlicerSurfaceToolbox#72 - Slicer/SlicerSurfaceToolbox#73 - Slicer/SlicerSurfaceToolbox#74 - Slicer/SlicerSurfaceToolbox#75 List of changes: ``` $ git shortlog 26715cf..389b220 --no-merges Ye Han (5): [Backport PR-71] ENH:Add MeshAlignment module [Backport PR-72] ENH: Add MeshDataImprinter module [Backport PR-73] ENH: Add SurfaceFeatureExtractor module [Backport PR-74] ENH: Add SurfaceDistance Module [Backport PR-75] ENH: Add AverageMesh module ```
jcfr
added a commit
to Kitware/SlicerSALT
that referenced
this pull request
Apr 17, 2025
…dates This commit updates Slicer to include the MeshAlignment module added to the the SlicerSALT fork of SlicerSurfaceToolbox. The changes correspond to those proposed in Slicer/SlicerSurfaceToolbox#71, which are still under review and not yet merged upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mesh alignment module take a target model and a selection of source models and align the source models to the target model either by iterative closest point (generic surface) or procrustes (point correspondence required). You may test the module using the test data
meshalignment_testdata.tar.gz
I will add test later using this data if everything is looks good for the module.
The parameters are all saved the parameter node, except for the source node selection since qMRMLCheckableNodeComboBox is not yet supported for parameter node (Slicer/Slicer#7308). If there is a strong preference for creating a custom parameter node or common parameter node utils to include widgets that generate list or selections of any type, I'd be down to learn and help add the support. I also have AverageMesh and SurfaceDistance module in hand which takes input as a list/selection of models similar to this module, but I will wait for the comments on this PR to refine those so that they can be reviewed more efficiently. Thanks!
ref: #68 Kitware/SlicerSALT#312 #6
fyi: @bpaniagua