Skip to content

refactor patching logic #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

refactor patching logic #104

wants to merge 7 commits into from

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 27, 2022 •
edited
Loading

This is a very early prototype of a refactoring I have in mind. Posting this here for CI 😇

@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #104 (6c544a6) into main (8e37c9b) will decrease coverage by 1.0%.
The diff coverage is 58.0%.

❗ Current head 6c544a6 differs from pull request most recent head c01c79a. Consider uploading reports for the commit c01c79a to get more accurate results

@@           Coverage Diff           @@
##            main    #104     +/-   ##
=======================================
- Coverage   83.6%   82.6%   -1.0%     
=======================================
  Files          5       6      +1     
  Lines        354     392     +38     
=======================================
+ Hits         296     324     +28     
- Misses        58      68     +10
Flag Coverage Δ
unit 82.6% <58.0%> (-1.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
light_the_torch/_patch.py 80.6% <33.3%> (+5.1%) ⬆️
light_the_torch/_packages.py 65.2% <65.2%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 19, 2023

In the aftermath of #115, we need this even more.

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 23, 2023

The general functionality is there, but we still need to merge with main. Will send more PRs against this one to minimize the risk botching this.

@pmeier
Copy link
Collaborator Author

pmeier commented Jan 23, 2023 •
edited
Loading

The following PRs need to be ported:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmeier