COMP: Fix IPOPT packaging in Windows - #329
Open
xskere wants to merge 1 commit into
Open
Conversation
cpinter
reviewed
Jul 2, 2026
| ) | ||
| endforeach() | ||
|
|
||
| # Also install the DLLs for packaging. Ipopt is a prebuilt zip on Windows (not a CMake |
Member
There was a problem hiding this comment.
Shouldn't we put this in an if (WIN32)? Not sure if this would break the packaging on Linux
Collaborator
Author
There was a problem hiding this comment.
It's inside if(EXTENSION_BUILDS_IPOPT AND WIN32 AND DEFINED Ipopt_DLL_DIR) so it should be already covered on that. Also I tested build + packaging on both Windows and Linux and it worked fine for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPACK_INSTALL_CMAKE_PROJECTSrequires every listed directory to be a CMake build tree with a generatedcmake_install.cmake. The Mumps/HSL/Ipopt entries pointed at autotools install prefixes (Unix) or a prebuilt binaries zip extraction (Windows), none of which are CMake projects, so package failed with a generic "Error when generating package: SlicerRT" whenever EXTENSION_BUILDS_IPOPT=ON.Removed those three entries from
CPACK_INSTALL_CMAKE_PROJECTSin the top-level CMakeLists.txt.Added a proper
install()rule inExternalBeamPlanning/Widgets/CMakeLists.txtso the IPOPT DLLs are installed as part of that module (which is a real CMake target with a valid install script) instead.With this fix, both build and package work on Windows and Linux.
Re #298