Drop Jars at feet if no inventory room, or add to inventory#38
Open
test137E29B wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
Open
Drop Jars at feet if no inventory room, or add to inventory#38test137E29B wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
test137E29B wants to merge 1 commit intoSlimefun-Addon-Community:masterfrom
Conversation
Contributor
Author
|
@TheBusyBiscuit Any update on this one, it's quite a pain on public servers in their grinders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a free inventory slot, add the jar to the inventory, otherwise drop it at the Killer's feet instead of the mob's position.
The problem is that in grinder's, or with mobs that can pick up items, a soul jar can get "lost" in a regular hopper or picked up by the mob requiring the mob to be killed to get the jar back. This prevents the kill from counting to the jar's soul count.
It makes more sense to give it back to the user in a much more streamlined way such as this in my opinion.