Skip to content

Re-Open add maileke air quality detector #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lelandblue
Copy link
Contributor

Check all that apply

Type of Change

  • [ X] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

I accidentally merged 1850, which has been reverted out of main in PR: 2098. The purpose of this PR is to re-open the changes submitted in 1850 so WWST Testing can proceed.

Summary of Completed Tests

@lelandblue lelandblue requested a review from greens April 29, 2025 19:40
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@lelandblue
Copy link
Contributor Author

Hello @thinkaName , @greens - Please see this PR, I am sorry for the issue that I caused.

Copy link

Copy link

Test Results

   67 files    426 suites   0s ⏱️
2 182 tests 2 182 ✅ 0 💤 0 ❌
3 718 runs  3 718 ✅ 0 💤 0 ❌

Results for commit 032c670.

Copy link

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-air-quality-detector/src/MultiIR/init.lua 86%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 032c670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants