Skip to content

Revert "Exclude off from fanMode capability for Thermostats (#2673)" #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickolas-deboom merged 1 commit into from
Jan 20, 2026
Merged

Revert "Exclude off from fanMode capability for Thermostats (#2673)" #2715

nickolas-deboom merged 1 commit into from
Jan 20, 2026
+12 −22

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jan 20, 2026

This reverts commit b8b7068, which will require additional discussion before going forward.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Test Results

   71 files    480 suites   0s ⏱️
2 488 tests 2 488 ✅ 0 💤 0 ❌
4 271 runs  4 271 ✅ 0 💤 0 ❌

Results for commit 18436d1.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/capability_handlers.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/utils.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/embedded_cluster_utils.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/legacy_device_configuration.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 98% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 18436d1

@nickolas-deboom nickolas-deboom merged commit 2192441 into main Jan 20, 2026
11 checks passed
@nickolas-deboom nickolas-deboom deleted the revert-removing-thermostat-fan-off-mode branch January 20, 2026 19:27
nickolas-deboom added a commit that referenced this pull request Jan 20, 2026
@nickolas-deboom
Revert "Exclude off from fanMode capability for Thermostats (#2673)" (#…
2a95363 
…2715)

This reverts commit b8b7068.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpmanley tpmanley tpmanley approved these changes

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@greens greens Awaiting requested review from greens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickolas-deboom @tpmanley @hcarter-775