Skip to content

Conversation

@NoahCornell
Copy link
Contributor

@NoahCornell NoahCornell commented Jan 20, 2026

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

As part of the 59 IPC rework between hubcore and the runner, the environment info events for augmented driver store changed erroneously and so the parsing being done by the default driver handler is no longer correct. The values in the store will be correct after a driver/hub restart but upserts outside of a restart will not be applied.

This mostly effects the sonos driver (other drivers may not immediately apply some configs) since the driver will not be able to update its oauth token once it expires (every 24 hours). When the driver receives a capability command and the token is expired, there is a 30 second period where the driver will wait for the token to be refreshed so that the capability command will not fail.

Users have Sonos linked in the ST app will see either:

  • Speakers be uncontrollable, if 3rd party oauth is enabled in the Sonos app
  • 30 seconds delays, if 3rd party oauth is disabled in the Sonos app

I will make a similar change in scripting-engine to handle both before and after the changes in 59.

Summary of Completed Tests

I have tested that upserts are now applied with these changes and the token refresher task is able to update invalid tokens again.

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Test Results

   71 files  ±0    480 suites  ±0   0s ⏱️ ±0s
2 488 tests ±0  2 488 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 271 runs  ±0  4 271 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06762b7. ± Comparison against base commit 2192441.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 06762b7

This was broken in hubcore 59 due to IPC rework.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants