CHAD-17218: Fix Sonos augmented driver store upserts #2721
+58
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
As part of the 59 IPC rework between hubcore and the runner, the environment info events for augmented driver store changed erroneously and so the parsing being done by the default driver handler is no longer correct. The values in the store will be correct after a driver/hub restart but upserts outside of a restart will not be applied.
This mostly effects the sonos driver (other drivers may not immediately apply some configs) since the driver will not be able to update its oauth token once it expires (every 24 hours). When the driver receives a capability command and the token is expired, there is a 30 second period where the driver will wait for the token to be refreshed so that the capability command will not fail.
Users have Sonos linked in the ST app will see either:
I will make a similar change in scripting-engine to handle both before and after the changes in 59.
Summary of Completed Tests
I have tested that upserts are now applied with these changes and the token refresher task is able to update invalid tokens again.