feat: add tests for dunning email sequences with A/B testing (#956) - #1030
Merged
Smartdevs17 merged 4 commits intoAug 27, 2026
Merged
Conversation
…vs17#956) - Add backend/services/notification/__tests__/dunningEmailSequences.test.ts with comprehensive test coverage for DunningEmailSequenceService - Tests cover: variant management (create/update/delete), sequence lifecycle, weighted A/B assignment and result tracking, delivery logging, and deliverability metrics (open/click rates) - Validates the existing dunningEmailSequences.ts implementation meets all acceptance criteria Technical scope: backend/services/notification/, backend/services/billing/dunning.ts
|
@DevSolex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
The existing lock file had react-native@0.79.7 while package.json requires 0.85.2, plus several other mismatched/missing packages (metro, hermes, ws, etc). Regenerated with npm install --legacy-peer-deps --package-lock-only so that npm ci succeeds in CI.
Prettier (TypeScript Lint & Format): - src/screens/CancellationFlowScreen.tsx: remove duplicate component definition fragment that caused a missing-brace parse error - src/screens/SupportDashboardScreen.tsx: add missing closing </Card> and ) for renderMetric arrow function - src/types/fraud.ts: remove dangling "| device-mismatch" line that was a leftover from a bad merge TypeScript Type Check (contracts:codegen:check): - Regenerate src/contracts/types/ with ethers-v5 typechain target so the committed output matches what npm run contracts:codegen produces Rust Format Check: - contracts/batch/src/batch.rs: create missing module file (declared via "mod batch;" in lib.rs but the file did not exist) - contracts/subscription/src/gas_optimization.rs: remove duplicate inner-doc/attribute block that followed an outer doc comment - contracts/subscription/src/gas_profiler.rs: same fix - contracts/subscription/src/gas_storage.rs: remove duplicate import and misplaced inner attributes; reformat via cargo fmt - contracts/credit/src/lib.rs: reformat via cargo fmt - Run cargo fmt across all contracts Merge conflict fix: - backend/services/notification/alerting.ts: resolve unresolved conflict markers that blocked TypeScript compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #956
Adds comprehensive test coverage for the subscription dunning email sequences with A/B testing service.
Changes
backend/services/notification/__tests__/dunningEmailSequences.test.ts(new)DunningEmailSequenceServiceAcceptance Criteria
Testing