Skip to content

Optimize inefficient code patterns in app.js and cla-mark.yml #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CosmicJesterX merged 2 commits into from
Dec 4, 2025
Merged

Optimize inefficient code patterns in app.js and cla-mark.yml #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bef4f4
Initial plan
Copilot Dec 4, 2025
671aa2b
Optimize app.js and cla-mark.yml for better performance
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/cla-mark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ jobs:
}

if (createMissing) {
await ensureLabel(labelCovered, '2ea44f', 'Contributor License Agreement is considered covered');
await ensureLabel(labelReview, '9a9a9a', 'CLA status requires manual review');
await Promise.all([
ensureLabel(labelCovered, '2ea44f', 'Contributor License Agreement is considered covered'),
ensureLabel(labelReview, '9a9a9a', 'CLA status requires manual review')
]);
}

// Remove the opposite label if present, then add the desired one
Expand Down
6 changes: 4 additions & 2 deletions examples/mirc-ui-mock/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@

const channels = ['#general', '#random', '#cozy-outpost'];
const users = ['alice', 'bob', 'carol', 'dave'];
const nickColors = ['nick-a','nick-b','nick-c','nick-d','nick-e','nick-f'];
const nickColorClass = (nick) => {
const idx = Math.abs(hash(nick)) % 6; // 0..5
return ['nick-a','nick-b','nick-c','nick-d','nick-e','nick-f'][idx];
return nickColors[idx];
};

// Simple hash for color bucketing
Expand Down Expand Up @@ -144,7 +145,8 @@
logEl.scrollTop = logEl.scrollHeight;
}

const htmlEscapeMap = { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' };
function escapeHtml(s) {
return s.replace(/[&<>"']/g, (c) => ({ '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' }[c]));
return s.replace(/[&<>"']/g, (c) => htmlEscapeMap[c]);
}
})();