[WIP] [Catalog] Feature #3464, migrate legacy product positions in categories to ElasticSuite #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…categories to ElasticSuite
romainruaud
reviewed
Sep 29, 2025
| $rows = $connection->fetchAll($select); | ||
|
|
||
| if (!$rows) { | ||
| $output->writeln("<comment>No products found for category {$categoryId}</comment>"); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
reviewed
Sep 29, 2025
| } | ||
|
|
||
| if (!$silentMode) { | ||
| $output->writeln("<info>Found " . count($rows) . " products</info>"); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
reviewed
Sep 29, 2025
|
|
||
| // Step 3: persist or preview. | ||
| if ($dryRun) { | ||
| $output->writeln("<comment>[Dry-Run]</comment> Category {$categoryId}: would migrate " . count($normalized) . " products."); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
reviewed
Sep 29, 2025
| if ($dryRun) { | ||
| $output->writeln("<comment>[Dry-Run]</comment> Category {$categoryId}: would migrate " . count($normalized) . " products."); | ||
| if (!empty($toDelete)) { | ||
| $output->writeln("<comment>[Dry-Run]</comment> Would delete " . count($toDelete) . " products due to conflicts."); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
reviewed
Sep 29, 2025
| $table, | ||
| ['category_id = ?' => $categoryId, 'product_id IN (?)' => $toDelete] | ||
| ); | ||
| $output->writeln("<comment>Deleted " . count($toDelete) . " products due to conflicts.</comment>"); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
reviewed
Sep 29, 2025
| } | ||
|
|
||
| $connection->commit(); | ||
| $output->writeln("<info>Category {$categoryId}: migrated " . count($normalized) . " products.</info>"); |
There was a problem hiding this comment.
It's not "products" but "products positions".
romainruaud
requested changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.