Skip to content

ffbs-mesh-vpn-parker: delete firewall rules for the prefix6 site config#2

Merged
SmithChart merged 1 commit intoSmithChart:ffbs-parker-nodeconfigfrom
grische:migrate/remove-prefix6-prefix4
Dec 15, 2024
Merged

ffbs-mesh-vpn-parker: delete firewall rules for the prefix6 site config#2
SmithChart merged 1 commit intoSmithChart:ffbs-parker-nodeconfigfrom
grische:migrate/remove-prefix6-prefix4

Conversation

@grische
Copy link
Collaborator

@grische grische commented Nov 27, 2024

@SmithChart
Copy link
Owner

I do not understand how this is the same change. For me both matches look vastly different.

Also: The commit messages and commit reference different entries.
Please elaborate what this change does and how it makes the other rule obsolete.
While you are on it: Please extent the commit message to describe why this change is needed not only what it changes, as this is already part of the diff.

@maurerle
Copy link
Collaborator

maurerle commented Nov 27, 2024

Hi @SmithChart ,
the commit chunk ffbs/gluon-parker@2e53380#diff-70c0178fef0afe6aa581fdd24bcd19c5ad4f04874648698469f5f5896dc1b500L36
Deletes the uci rule mesh_respondd_siteprefix from gluon, which is added in 400-respondd-firewall at gluon upgrades

The chunk in this PR adds a script to 401- respondd-firewall so directly after the above addition to delete any firewall rule called mesh_respondd_siteprefix

In both cases the role does not exist anymore after the upgrade.
Of course, deleting things directly after they were added seems weird, but it is better in this case as it reduces the differences to gluon required for Parker

The mesh_respondd_siteprefix and mesh_respondd_extraprefix[0-9]+ rules
do not make sense in the context of parker as there are no prefix4
and prefix6 attributes anymore.

Based on
ffbs/gluon-parker@2e53380#diff-70c0178fef0afe6aa581fdd24bcd19c5ad4f04874648698469f5f5896dc1b500L36-L43
@grische grische force-pushed the migrate/remove-prefix6-prefix4 branch from b494771 to ca49163 Compare November 28, 2024 09:36
@grische
Copy link
Collaborator Author

grische commented Nov 28, 2024

Also added the code comment as a git commit message.

@grische grische requested a review from SmithChart December 8, 2024 09:48
@SmithChart
Copy link
Owner

Thanks for clarifying! It makes sense this way. I will drop the hunk from the key once this is merged.

@SmithChart SmithChart merged commit e6e5ca6 into SmithChart:ffbs-parker-nodeconfig Dec 15, 2024
@SmithChart
Copy link
Owner

FTR: Hunk dropped by force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants