Skip to content

Let resource limits (threads + memory) be overridable #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slinjhu merged 1 commit into from
May 6, 2026
Merged

Let resource limits (threads + memory) be overridable #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions smoosense-py/smoosense/utils/duckdb_connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@

@validate_call()
def duckdb_connection_default() -> DuckdbConnectionMaker:
# Optional caps via env vars; if unset, DuckDB picks defaults from the cgroup / nproc.
memory_limit = os.getenv("SMOOSENSE_DUCKDB_MEMORY_LIMIT")
threads = os.getenv("SMOOSENSE_DUCKDB_THREADS")

def maker() -> DuckDBPyConnection:
con = duckdb.connect()

if memory_limit:
con.execute(f"SET memory_limit='{memory_limit}'")
if threads:
con.execute(f"SET threads={threads}")
# Now install and load the extension
con.execute("INSTALL httpfs")
con.execute("LOAD httpfs")
Expand All @@ -32,7 +40,6 @@ def maker() -> DuckDBPyConnection:
@validate_call(config=ConfigDict(arbitrary_types_allowed=True))
def duckdb_connection_using_s3(
s3_client: BaseClient | None = None,
memory_limit: str = "3GB",
) -> DuckdbConnectionMaker:
if s3_client is None:
s3_client = boto3.client("s3")
Expand Down Expand Up @@ -62,7 +69,6 @@ def maker() -> DuckDBPyConnection:
# Set home_directory and temp_directory before httpfs auto-installs
con.execute(f"SET home_directory='{home_directory}'")
con.execute(f"SET temp_directory='{temp_directory}'")
con.execute(f"SET memory_limit='{memory_limit}'")

# Now install and load the extension
con.execute("INSTALL httpfs")
Expand Down
Loading