Skip to content

randomfileadded #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

randomfileadded #82

wants to merge 1 commit into from

Conversation

eshant742
Copy link

random.ts file added in src which implements the required functions

@Smoren
Copy link
Owner

Smoren commented Feb 13, 2025

Hi @eshant742! Thank you for your PR!

There are a few things that need to be fixed and completed before I can merge it.

  1. You have created objects Stream and AsyncStream in the file random.ts with method rockPaperScissors. Instead, you have to add these methods to the existing Stream and AsyncStream classes (see files stream.ts, async-stream.ts).

  2. Please export the new functions (rockPaperScissors and rockPaperScissorsAsync) in the file index.ts.

  3. The new functions and methods need to be covered by tests, similar to how the previously implemented functions and methods are tested.

If you have any questions, feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants