Skip to content

Fix toast notification duration consistency #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Salman-Ahamed wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −5
Open

Fix toast notification duration consistency #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/app/src/shared/components/toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function toastWithIcon(
const notify = Metro.notify;

// Default timeout of 5 seconds if not specified
const toastTimeout = options.timeout || 5000;
const toastTimeout = options.timeout ?? 5000;

// Toast type specific settings
const typeConfig = {
Expand Down Expand Up @@ -103,9 +103,7 @@ export function toastWithIcon(
<div class="toast-progress-bar-container w-full h-1 mt-3 rounded-full overflow-hidden" style="background-color: ${
config.progressBarBackgroundColor
};">
<div class="toast-progress-bar h-full" style="width: 100%; transition: width ${
options.timeout || 5000
}ms linear; background-color: ${config.progressBarColor};"></div>
<div class="toast-progress-bar h-full" style="width: 100%; transition: width ${toastTimeout}ms linear; background-color: ${config.progressBarColor};"></div>
</div>
${ctaButtonHtml}
</div>
Expand All @@ -124,7 +122,7 @@ export function toastWithIcon(
if (!toastElement) return;

// Store the timeout duration for use in calculations
const timeoutDuration = options.timeout || 5000;
const timeoutDuration = toastTimeout;

// Set up our own timeout for closing the toast
let closeTimeout;
Expand Down