Skip to content

fix: leading zeros in the inputs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: leading zeros in the inputs #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd9476
fix: leading zeros in the inputs
mslowin Jun 25, 2025
8c22622
Refactor: update input handling to properly remove leading zeros and …
mslowin Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/features/workout-session/ui/workout-session-set.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,26 @@ export function WorkoutSessionSet({ set, setIndex, onChange, onFinish, onRemove
onChange(setIndex, { types: newTypes });
};

const handleValueIntChange = (columnIndex: number) => (e: React.ChangeEvent<HTMLInputElement>) => {
const handleValueFloatChange = (columnIndex: number) => (e: React.ChangeEvent<HTMLInputElement>) => {
e.target.value = e.target.value === "" ? "" : String(Number(e.target.value)) || "0";
let value = e.target.value ? parseFloat(e.target.value) : 0;

// Truncate to 2 decimal places
if (!Number.isNaN(value)) {
const parts = e.target.value.split(".");
if (parts.length === 2) {
// Keep only first 2 digits after decimal
value = parseFloat(parts[0] + "." + parts[1].slice(0, 2));
}
}

const newValuesInt = Array.isArray(set.valuesInt) ? [...set.valuesInt] : [];
newValuesInt[columnIndex] = e.target.value ? parseInt(e.target.value, 10) : 0;
newValuesInt[columnIndex] = value;
onChange(setIndex, { valuesInt: newValuesInt });
};

const handleValueSecChange = (columnIndex: number) => (e: React.ChangeEvent<HTMLInputElement>) => {
e.target.value = e.target.value === "" ? "" : String(Number(e.target.value)) || "0";
const newValuesSec = Array.isArray(set.valuesSec) ? [...set.valuesSec] : [];
newValuesSec[columnIndex] = e.target.value ? parseInt(e.target.value, 10) : 0;
onChange(setIndex, { valuesSec: newValuesSec });
Expand Down Expand Up @@ -84,7 +97,7 @@ export function WorkoutSessionSet({ set, setIndex, onChange, onFinish, onRemove
className="border border-black rounded px-1 py-2 w-1/2 text-base text-center font-bold dark:bg-slate-800 dark:placeholder:text-slate-500"
disabled={set.completed}
min={0}
onChange={handleValueIntChange(columnIndex)}
onChange={handleValueFloatChange(columnIndex)}
pattern="[0-9]*"
placeholder="min"
type="number"
Expand All @@ -110,7 +123,7 @@ export function WorkoutSessionSet({ set, setIndex, onChange, onFinish, onRemove
className="border border-black rounded px-1 py-2 w-1/2 text-base text-center font-bold dark:bg-slate-800"
disabled={set.completed}
min={0}
onChange={handleValueIntChange(columnIndex)}
onChange={handleValueFloatChange(columnIndex)}
pattern="[0-9]*"
placeholder=""
type="number"
Expand All @@ -133,7 +146,7 @@ export function WorkoutSessionSet({ set, setIndex, onChange, onFinish, onRemove
className="border border-black rounded px-1 py-2 w-full text-base text-center font-bold dark:bg-slate-800"
disabled={set.completed}
min={0}
onChange={handleValueIntChange(columnIndex)}
onChange={handleValueFloatChange(columnIndex)}
pattern="[0-9]*"
placeholder=""
type="number"
Expand Down