feat(korean-locale): add new korean locale#120
Conversation
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there! Thanks so much for adding Korean support that's a huge help. Since our last update the translation system got a bit more involved than just JSON files. You'll now find keys like A good first step is to grep for those and see where each locale needs a migration script. Once you spot them, you can:
Feel free to grab whichever step sounds fun in the issues, and we'll be right here to review your PR |
Okay, I understand that additional work is required. This will likely take some more time. I will add the changes to this PR as soon as they are ready. |
|
@Snouzy |
Snouzy
left a comment
Snouzy
left a comment
There was a problem hiding this comment.
Hey there! wow, this Korean support is really solid .! Huge congrats on getting it all done It’s already looking super smooth.
Whenever you’ve got a sec, could you peek at my tiny comments and let me know what you think? Can't wait to merge this :) thanks for all the hard work !
| titlePt: data.titlePt, | ||
| titleRu: data.titleRu, | ||
| titleZhCn: data.titleZhCn, | ||
| titleKo: data.titleZhCn, |
| descriptionPt: z.string().min(1, "La description en portugais est requise"), | ||
| descriptionRu: z.string().min(1, "La description en russe est requise"), | ||
| descriptionZhCn: z.string().min(1, "La description en chinois est requise"), | ||
| descriptionKo: z.string().min(1, "La description en chinois est requise"), |
There was a problem hiding this comment.
La description en cooréen est requise
| titlePt: z.string().min(1, "Le titre en portugais est requis"), | ||
| titleRu: z.string().min(1, "Le titre en russe est requis"), | ||
| titleZhCn: z.string().min(1, "Le titre en chinois est requis"), | ||
| titleKo: z.string().min(1, "Le titre en chinois est requis"), |
| titlePt: z.string().min(1, "Le titre en portugais est requis"), | ||
| titleRu: z.string().min(1, "Le titre en russe est requis"), | ||
| titleZhCn: z.string().min(1, "Le titre en chinois est requis"), | ||
| titleKo: z.string().min(1, "Le titre en chinois est requis"), |
| descriptionPt: z.string().min(1, "La description en portugais est requise"), | ||
| descriptionRu: z.string().min(1, "La description en russe est requise"), | ||
| descriptionZhCn: z.string().min(1, "La description en chinois est requise"), | ||
| descriptionKo: z.string().min(1, "La description en chinois est requise"), |
There was a problem hiding this comment.
La description en coréen est requise
| titlePt: program.titlePt, | ||
| titleRu: program.titleRu, | ||
| titleZhCn: program.titleZhCn, | ||
| titleKo: program.titleZhCn, |
| descriptionPt: program.descriptionPt, | ||
| descriptionRu: program.descriptionRu, | ||
| descriptionZhCn: program.descriptionZhCn, | ||
| descriptionKo: program.descriptionZhCn, |
| titlePt: z.string().min(1, "Le titre en portugais est requis"), | ||
| titleRu: z.string().min(1, "Le titre en russe est requis"), | ||
| titleZhCn: z.string().min(1, "Le titre en chinois est requis"), | ||
| titleKo: z.string().min(1, "Le titre en chinois est requis"), |
| case "zh-CN": | ||
| return ex.exercise.nameZhCn || ex.exercise.nameEn; | ||
| case "ko": | ||
| return ex.exercise.nameKo || ex.exercise.nameKo; |
There was a problem hiding this comment.
return ex.exercise.nameKo || ex.exercise.nameEn;
|
@Snouzy Thanks for the thorough review! |
2 participants
📝 Description
Added a new Korean (ko) locale to the application.
I am very interested in this project and would like to contribute more. If you could point me to any simple, upcoming contribution points, I would love to give them a try. 😄
📋 Checklist
🗃️ Prisma Migrations (if applicable)
📸 Screenshots (if applicable)
🔗 Related Issues