fix: add retry support for health checks - #30
Open
naufalfx805-source wants to merge 2 commits into
Open
Conversation
Author
|
This PR addresses the health check retry support described in the original issue scope. Ready for review. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable retry/backoff support for transient HTTP and TCP health-check failures so temporary connection refused or timeout conditions can recover before returning
CRITICAL.Closes #2.
Changes
--retriesand--retry-backoffCLI flags.--retries 0.attemptsandlatency_msmetadata to JSON health-check output.tools/health_check_retry_harness.pycovering success-after-retry, exhausted-retry, and JSON retry metadata.Testing
Ran locally:
Results:
py_compilepassed.health check retry harness passed.--retriesand--retry-backoff.attemptsandlatency_ms.python build.pyinitially hit Windows console encoding for the warning symbol, so I reran withpython -X utf8 build.py.encryptlycould not create a.logdartifact in this local environment. The generated diagnostic JSON is committed atdiagnostic/build-3d7f3362.jsonand records the blocker.Checklist