Skip to content

Refresh manage-zerocopy-sapbdc with v1.1.0 audit pass#15

Open
jdanielmyers wants to merge 1 commit into
mainfrom
refresh/manage-zerocopy-sapbdc
Open

Refresh manage-zerocopy-sapbdc with v1.1.0 audit pass#15
jdanielmyers wants to merge 1 commit into
mainfrom
refresh/manage-zerocopy-sapbdc

Conversation

@jdanielmyers
Copy link
Copy Markdown
Member

Summary

Runs the existing manage-zerocopy-sapbdc skill through the v1.1.0 audit pipeline. The holistic rewriter applied:

  • Audit-driven mechanical fixes (1 blocking + 7 advisory checks addressed in the previous round)
  • A builder-audience pass that strips any internal-Snowflake framing while preserving the SAP BDC technical content (which is built on a public feature)
  • README.md updated to reference Snowflake-Labs repo instead of internal Snowflake-Solutions

Test plan

  • audience.no_internal_refs passes on the new SKILL.md
  • check_residual_blocking.py exits 0 against the staged version
  • Frontmatter matches Labs conventions (all required fields present, tools list format, proper quoting)
  • No nested SKILL.md in sub-skill directories
  • No Snowflake-Solutions references remaining
  • LICENSE present
  • YAML frontmatter parses cleanly

Post-rewrite residual

  • 0 blocking failures
  • 2 advisory: tdd.body.has_when_to_use and tdd.body.word_budget (soft style guidelines, acceptable)

@jdanielmyers
Copy link
Copy Markdown
Member Author

jdanielmyers commented May 20, 2026

Audit Report: manage-zerocopy-sapbdc

Re-audit (post-v1.1.1 + critical fixes). Original report superseded.

Summary

Category 🔴 🟡 🟢
Frontmatter 0 0 0
Structure 0 1 1
Workflow 0 0 1

Critical 🔴

None — all critical findings from the original audit have been addressed.

Warnings 🟡

  1. Sub-flow publish/INSTRUCTIONS.md is 519 lines (exceeds 500-line guideline) → Consider extracting the CSN generation section to its own file (a csn-generator/ sub-flow already exists, so verify it's being leveraged to reduce publish/ size).

Suggestions 🟢

  1. The router SKILL.md (134 lines) is well-structured — the menu in Step 1 is clear, stopping points are present, and sub-flows are well-documented.
  2. Consider adding a demo-url value to the frontmatter (currently empty string).

Verdict

Ready to merge — Router is clean, stopping points are correct, sub-flows exist and are referenced properly. The 519-line sub-flow is a minor concern but doesn't block merge.

@jdanielmyers jdanielmyers force-pushed the refresh/manage-zerocopy-sapbdc branch from 9feaeee to a1b0b06 Compare May 20, 2026 20:46
Re-staged with v1.1.1 holistic prompt that adds stopping-point markers,
correct INSTRUCTIONS.md sub-flow cross-refs, and drops invalid tool
snowflake_object_search.
@jdanielmyers jdanielmyers force-pushed the refresh/manage-zerocopy-sapbdc branch from a1b0b06 to f5ab97a Compare May 20, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant