Pushdown uuid functions#173
Open
sfc-gh-abozkurt wants to merge 1 commit into
Open
Conversation
sfc-gh-abozkurt
force-pushed
the
aykut/pushdown-uuid-funcs
branch
8 times, most recently
from
969d1a5 to
de3bdc5
Compare
sfc-gh-abozkurt
force-pushed
the
aykut/pushdown-uuid-funcs
branch
3 times, most recently
from
b35c8d4 to
d94b00d
Compare
sfc-gh-mslot
reviewed
Apr 1, 2026
| // Extract individual bytes from the UUID (bytes 0-7 are in upper) | ||
| // We already have unsigned_upper computed above | ||
| uint8_t data[8]; | ||
| for (int i = 0; i < 8; i++) { |
Collaborator
There was a problem hiding this comment.
does this code work? i is already used in the outer loop
Collaborator
Author
There was a problem hiding this comment.
works as it shadows the outer but I ll change it, it looks fishy.
Signed-off-by: Aykut Bozkurt <aykut.bozkurt@snowflake.com>
sfc-gh-abozkurt
force-pushed
the
aykut/pushdown-uuid-funcs
branch
from
d94b00d to
bee896e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
NOTE:
uuid_extract_timestampreturns timestamp only for uuid v1 in pg17 but it returns timestamp for v1 and v7 above pg18. This is why we pass postgres version num to duckdb function.Co-authored-by: manojks1999 9743manoj@gmail.com