Send Token to Kusama #1463

claravanstaden · 2025-04-29T11:58:38Z

Adds API layer forKusama
Test scripts for transferring Weth and Dot from Polkadot to Kusama and back.

# Conflicts: # web/packages/operations/package.json # web/packages/operations/src/transfer_token_v2.ts

# Conflicts: # web/packages/api/package.json # web/packages/contract-types/package.json # web/packages/contracts/package.json

# Conflicts: # web/packages/api/package.json # web/packages/api/src/assets_v2.ts # web/packages/api/src/xcmBuilder.ts # web/pnpm-lock.yaml

claravanstaden · 2025-05-22T12:21:39Z

@yrong sure, https://assethub-kusama.subscan.io/extrinsic/9407589-2. There is a KSM amount minted yeah.

acatangiu · 2025-05-22T12:31:21Z

I sent WETH from Kusama to Polkadot, and my KSM balance was lowered, even though I used DOT as fee. So I think KSM makes more sense to use as fee, right? Otherwise the user needs some DOT and some KSM, which is bad UX.

yes, try to use native whenever possible, I expect requiring KSM on Kusama side to be better UX than requiring DOT there - either way, if the source is KAH or PAH, the UI could check pools and do some swap before to cover all fees using only WETH

claravanstaden · 2025-05-22T12:51:57Z

To summarize the changes that I'll make:

Change the fee asset from K->P to KSM
Use the Balances::Minted event from the dry run (same for P->K direction) as the execution fee (so total fee would be Balances::Minted + delivery fee) @alistair-singh let me know if you agree with this? This will replace getting the XcmBridgeHubRouterBaseFee from storage (and calculating the message fee per byte, which I have not implemented)

yrong · 2025-05-22T15:12:10Z

Use the Balances::Minted event from the dry run (same for P->K direction) as the execution fee (so total fee would be Balances::Minted + delivery fee)

To be honest, after giving it more thought, I’m not sure the fee estimation justifies the complexity of introducing dry_run. The current API code already feels a bit too complicated.

In my opinion,the fee could be added as a static configuration value, which should work fine for both Snowbridge V1 and V2. I'd expect the fee is relatively stable and unlikely to change frequently, we wouldn’t need to reconfigure it often.

So, if possible, I’d prefer to do some cleanup rather than introduce more estimation logic and make things even more complex.

We can discuss it furthur tomorrow.

claravanstaden · 2025-05-23T10:52:49Z

@yrong I changed the fee from K->P to KSM, and added KSM as a transferable asset (with scripts): http://github.com/Snowfork/snowbridge/pull/1463/commits/cd0462175656a8494ca42314758cd13f4b332a31

Awaiting feedback on how to determine the fee: https://snowfork.slack.com/archives/G01BGMGLAC9/p1747993120325679 Once decided, I'll implement it.

yrong · 2025-05-23T16:15:08Z

Awaiting feedback on how to determine the fee

Either way works for me as long as the fee estimation is accurate. I don’t have a strong preference, so I’ll leave the decision to you or Alistair.

I may do some cleanup and refactoring to support Snowbridge V2, but that will be handled independently.

web/packages/api/src/forKusama.ts

web/packages/api/src/xcmBuilder.ts

# Conflicts: # web/packages/api/src/assets_v2.ts

alistair-singh

Just a dangling debug log command that needs to be removed.

alistair-singh · 2025-05-30T14:36:26Z

web/packages/api/src/assets_v2.ts

@@ -750,6 +856,7 @@ export function padFeeByPercentage(fee: bigint, padPercent: bigint) {
    if (padPercent < 0 || padPercent > 100) {
        throw Error(`padPercent ${padPercent} not in range of 0 to 100.`)
    }
+    console.log("PAD: ", fee * ((100n + padPercent) / 100n))


Remove this logging?

Removed in 90a7ddc.

yrong

+1

claravanstaden added 6 commits March 27, 2025 09:17

testing changes

9b78cbc

Merge branch 'refs/heads/main' into clara/send-token-kusama

4f43e33

# Conflicts: # web/packages/operations/package.json # web/packages/operations/src/transfer_token_v2.ts

kusama dry run

0e8693a

dry works

9ece596

send to kusama

71404a0

kusama progress

de91eda

github-actions bot added the Component: Web label Apr 29, 2025

claravanstaden added 21 commits May 2, 2025 12:21

kusama API

d1413b1

progress on API

3da042e

bridging back and forth works

a83da6a

Merge branch 'main' into clara/send-token-kusama

13f1c2e

adds statemine as spec

2cc1e73

fix registry issues

c9e516b

remove console log

46de191

adds kusama para indexing

4a88cf1

fees

f5e8e81

dry run on KAH

2800161

dryrunning and fees complete

be83717

Merge branch 'refs/heads/main' into clara/send-token-kusama

e75eda7

# Conflicts: # web/packages/api/package.json # web/packages/contract-types/package.json # web/packages/contracts/package.json

corner cases

6bbf4c4

dot transfers work

9b91226

api layer done

c912400

Merge branch 'main' into clara/send-token-kusama

be543c8

# Conflicts: # web/packages/api/package.json # web/packages/api/src/assets_v2.ts # web/packages/api/src/xcmBuilder.ts # web/pnpm-lock.yaml

remove comments

4f1c7d4

remove excessive logging

315815e

cleanup and update versions

87dffb0

uncomment moonbeam

c98ae85

cleanup

7ef19f3

claravanstaden marked this pull request as ready for review May 14, 2025 12:57

claravanstaden requested a review from alistair-singh May 14, 2025 12:58

adds ksm as fee for kusama to polkadot, and adds ksm transfers

cd04621

claravanstaden added 3 commits May 26, 2025 12:21

update dry run call args

2d7e55e

add dest fee

efb185a

fee per byte and dest execution fee

d4a85db

yrong reviewed May 26, 2025

View reviewed changes

web/packages/api/src/forKusama.ts Outdated Show resolved Hide resolved

claravanstaden added 5 commits May 27, 2025 10:38

fee per byte fix

df04168

fixes

5332510

unnecessary logs

39758f9

fixes

9c47572

fixes and format

0213b6d

yrong reviewed May 30, 2025

View reviewed changes

web/packages/api/src/xcmBuilder.ts Show resolved Hide resolved

yrong reviewed May 30, 2025

View reviewed changes

web/packages/api/src/xcmBuilder.ts Outdated Show resolved Hide resolved

claravanstaden added 3 commits May 30, 2025 15:48

pr comments

2fed1d6

Merge branch 'main' into clara/send-token-kusama

5a89fab

# Conflicts: # web/packages/api/src/assets_v2.ts

merge conflicts

7261a3d

claravanstaden requested review from yrong and alistair-singh May 30, 2025 13:51

bump packages

dbd9c3d

alistair-singh approved these changes May 30, 2025

View reviewed changes

yrong approved these changes May 30, 2025

View reviewed changes

claravanstaden added 2 commits June 2, 2025 10:10

remove log

90a7ddc

use existing method for swap

a549767

claravanstaden merged commit 64e54b6 into main Jun 2, 2025
1 check passed

claravanstaden deleted the clara/send-token-kusama branch June 2, 2025 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Send Token to Kusama #1463

Send Token to Kusama #1463

claravanstaden commented Apr 29, 2025 •

edited

Loading

Uh oh!

claravanstaden commented May 22, 2025

Uh oh!

acatangiu commented May 22, 2025

Uh oh!

claravanstaden commented May 22, 2025

Uh oh!

yrong commented May 22, 2025

Uh oh!

claravanstaden commented May 23, 2025

Uh oh!

yrong commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alistair-singh left a comment

Uh oh!

alistair-singh May 30, 2025

Uh oh!

claravanstaden Jun 2, 2025

Uh oh!

yrong left a comment

Uh oh!

Uh oh!

Uh oh!

Send Token to Kusama #1463

Send Token to Kusama #1463

Conversation

claravanstaden commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claravanstaden commented May 22, 2025

Uh oh!

acatangiu commented May 22, 2025

Uh oh!

claravanstaden commented May 22, 2025

Uh oh!

yrong commented May 22, 2025

Uh oh!

claravanstaden commented May 23, 2025

Uh oh!

yrong commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alistair-singh left a comment

Choose a reason for hiding this comment

Uh oh!

alistair-singh May 30, 2025

Choose a reason for hiding this comment

Uh oh!

claravanstaden Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

yrong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

claravanstaden commented Apr 29, 2025 •

edited

Loading