Open
Conversation
maxgfr
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
revu-bot
reviewed
Mar 26, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Review: fix(modale): correction des derniers retours UI
This PR addresses two UI feedback items from issue #7181:
- Removing the custom red "danger" styling from the "Supprimer" button to make it DSFR-compliant (blue).
- Removing a CSS focus-within hack that was causing tooltip visibility bugs.
Both changes are small, targeted, and correct. No critical issues found. One minor concern worth noting below.
| File | Lines | Severity | Issue |
|---|---|---|---|
HeaderAgreementButton.tsx |
83–87 | IMPORTANT | Tooltip accessibility regression — removing focus-within may hide tooltip from keyboard users |
maxgfr
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
maxgfr
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
maxgfr
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
maxgfr
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
maxgfr
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
maxgfr
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
|
|
🎉 Deployment for commit 8ee792c : IngressesDocker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7181