fix(search): update ES query in order to boost contrib #7229 #7217#7246
fix(search): update ES query in order to boost contrib #7229 #7217#7246
Conversation
rmelisson
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Summary: ES Query Boost Adjustments for Contributions
This PR tweaks Elasticsearch boost values to surface contributions results higher in search rankings, and silently disables the prequalified-results path.
| File | Lines | Severity | Issue |
|---|---|---|---|
service/search.ts |
52–53 | CRITICAL | Prequalified results permanently disabled with dead code left in place |
service/search.ts |
65, 88–92 | IMPORTANT | Commented-out console.log debug statements committed to main |
queries.ts |
255–258 | MINOR | SOURCES.TOOLS boost removed without explanation; implicit default boost is opaque |
Overall Assessment
The boost value changes themselves are straightforward tuning. The main concerns are the silent, permanent disabling of the prequalified-results feature (which leaves dead code and a misleading comment) and the committed debug console.log statements that should never reach production.
|
|
🎉 Deployment for commit 34a0f0a : Docker images
|
| // console.log( | ||
| // JSON.stringify(removeDuplicate(documents).slice(0, size), null, 2), | ||
| // elasticDocumentsIndex | ||
| // ); |
There was a problem hiding this comment.
Est-ce que ça vaut le coup de garder les commentaires dans le code pour logguer ?
3 participants
No description provided.