fix(search): fix exact match for theme presearch#7247
Open
Conversation
rmelisson
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
revu-bot
reviewed
Apr 21, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Summary: Fix exact match for theme presearch
This PR makes two changes:
- Removes an erroneous import of
queryAllByAltTextfrom@testing-library/reactin a non-test file (good cleanup). - Fixes the exact-match comparison for theme presearch by replacing
==withJSON.stringifycomparison on two arrays.
Critical Issue
The fix for array comparison is functionally correct (direct == on arrays always returns false unless same reference), but the chosen approach — JSON.stringify — is fragile and has known edge cases. A simpler, more idiomatic solution exists.
| File | Lines | Severity | Issue |
|---|---|---|---|
presearch.ts |
204–206 | CRITICAL | JSON.stringify for array equality is fragile; use a proper element-wise comparison |
|
maxgfr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.