Skip to content

feat(quoi-de-neuf): mise en avant de la page quoi de neuf.#7249

Open
m-maillot wants to merge 1 commit intodevfrom
feat/whats-new-highlight
Open

feat(quoi-de-neuf): mise en avant de la page quoi de neuf.#7249
m-maillot wants to merge 1 commit intodevfrom
feat/whats-new-highlight

Conversation

@m-maillot
Copy link
Copy Markdown
Contributor

@m-maillot m-maillot commented Apr 22, 2026

closes #7137

@m-maillot m-maillot requested a review from maxgfr April 22, 2026 10:38
@revu-bot revu-bot Bot requested a review from revu-bot April 22, 2026 10:38
@m-maillot m-maillot temporarily deployed to build-preproduction April 22, 2026 10:38 — with GitHub Actions Inactive
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary: feat(quoi-de-neuf) — Mise en avant de la page "Quoi de neuf"

This PR promotes the "Quoi de neuf" page by:

  1. Adding a WhatsNewLink sidebar component displayed on convention collective pages.
  2. Replacing the "Glossaire" footer link with the "Quoi de neuf" link.
  3. Extending ContainerRich and ContainerRichWithBreadcrumbs with an opt-in showWhatsNewLink prop.

The implementation is straightforward and low-risk. A few issues worth addressing:

File Lines Severity Issue
whatsnew/index.tsx 7 IMPORTANT Variable p used before declaration (hoisting risk + readability)
whatsnew/index.tsx 8–9 IMPORTANT Wrong DSFR icon class applied via fr.cx — icon tokens are not utility classes
AgreementContainer.tsx 36 MINOR Redundant boolean literal showWhatsNewLink={true}
FooterTop.tsx 10–13 IMPORTANT "Glossaire" link removed with no redirect — existing users/bookmarks will hit a 404

@tokenbureau
Copy link
Copy Markdown

tokenbureau Bot commented Apr 22, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment mettre davantage en avant la page "Quoi de neuf" ?

2 participants