feat(quoi-de-neuf): mise en avant de la page quoi de neuf.#7249
Open
feat(quoi-de-neuf): mise en avant de la page quoi de neuf.#7249
Conversation
|
revu-bot
reviewed
Apr 22, 2026
Collaborator
revu-bot
left a comment
There was a problem hiding this comment.
PR Summary: feat(quoi-de-neuf) — Mise en avant de la page "Quoi de neuf"
This PR promotes the "Quoi de neuf" page by:
- Adding a
WhatsNewLinksidebar component displayed on convention collective pages. - Replacing the "Glossaire" footer link with the "Quoi de neuf" link.
- Extending
ContainerRichandContainerRichWithBreadcrumbswith an opt-inshowWhatsNewLinkprop.
The implementation is straightforward and low-risk. A few issues worth addressing:
| File | Lines | Severity | Issue |
|---|---|---|---|
whatsnew/index.tsx |
7 | IMPORTANT | Variable p used before declaration (hoisting risk + readability) |
whatsnew/index.tsx |
8–9 | IMPORTANT | Wrong DSFR icon class applied via fr.cx — icon tokens are not utility classes |
AgreementContainer.tsx |
36 | MINOR | Redundant boolean literal showWhatsNewLink={true} |
FooterTop.tsx |
10–13 | IMPORTANT | "Glossaire" link removed with no redirect — existing users/bookmarks will hit a 404 |
revu-bot
reviewed
Apr 22, 2026
revu-bot
reviewed
Apr 22, 2026
revu-bot
reviewed
Apr 22, 2026
|
🎉 Deployment for commit 2f234a2 : IngressesDocker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



closes #7137