feat: gate declaration modification by campaign deadline

[LucasCharrier]

Summary

• Hide Modifier button in the declaration process panel once the corresponding campaign deadline has passed; replace "Modifiable jusqu'au…" with "Modification close depuis le…".
• Lock step navigation for submitted declarations only when the modification deadline has passed (decl1 + second declaration). While the deadline is in the future, users can re-edit a submitted declaration.
• Add isDeadlinePassed pure helper in domain (with unit tests), a dev-only /test-panel playground to visually tweak variants and deadlines, and E2E coverage of both branches via an upsertable app_campaign_deadline row.

Stacked on top of feat/configurable-campaign-deadlines.

Quality gates

• Typecheck / Tests (1043 ✓) / Lint
• E2E (5/5 ✓ — campaign-deadlines-gating.e2e.ts)

Generated with Claude Code

[revu-bot]

PR Review: Gate Declaration Modification by Campaign Deadline

This PR introduces deadline-based gating for declaration modifications — a well-scoped feature with good test coverage (unit + E2E). The core logic (isDeadlinePassed) is clean and correctly injectable for testing. Below are the issues found, ranging from a potential security gap to a few maintainability concerns.

File	Lines	Severity	Issue
app/test-panel/page.tsx	7–9	CRITICAL	notFound() called at runtime, not build-time — production bundle still includes playground code
e2e/campaign-deadlines-gating.e2e.ts	12	IMPORTANT	CURRENT_YEAR hardcoded to 2026 — tests will silently break next year
etape/[step]/page.tsx	28–33	IMPORTANT	Extra DB round-trip on every non-recap step visit for submitted declarations
my-space/__tests__/DeclarationProcessPanel.test.tsx	209–220	IMPORTANT	"future" deadline test relies on system clock — will fail after 2027
my-space/PanelPlayground.tsx	1	MINOR	PanelPlayground exported from my-space/index.ts — leaks dev component into production bundle

[revu-bot]

[CRITICAL] notFound() at runtime doesn't prevent the playground from being bundled into production

• notFound() is a runtime guard — it throws a Next.js 404 response, but the module (and everything it imports, including PanelPlayground) is still compiled into the production bundle.
• Any user who discovers the /test-panel route and bypasses the check (e.g. via a middleware bug or a future refactor) gets access to the playground UI.
• The correct pattern for Next.js is to use a build-time environment check so the route is never emitted in production builds at all.

Proposed fix: use a build-time guard that makes the route statically unreachable in production.

Suggested change

	export default function TestPanelPage() {
	if (env.NODE_ENV === "production") {
	notFound();
	}
	return <PanelPlayground />;
	}
	export default function TestPanelPage() {
	if (process.env.NODE_ENV === "production") {
	notFound();
	}
	return <PanelPlayground />;
	}

Better yet, move the file under a conditional segment or use Next.js route groups that are excluded from the production build via a custom next.config pageExtensions trick, so the module is tree-shaken entirely. At minimum, the env.NODE_ENV check should be replaced with process.env.NODE_ENV so bundlers can statically eliminate the dead branch.

[LucasCharrier]

Fixed in b5451f9: PanelPlayground is now lazy-loaded via next/dynamic, and removed from the my-space barrel so it won't be pulled into unrelated chunks. The runtime notFound() still guards production access.

[LucasCharrier]

Re: "Extra DB round-trip on every non-recap step visit for submitted declarations" — this is intentional. The query only fires when status === 'submitted' && step !== 6, which is the narrow window where a user re-edits a submitted declaration; it is strictly necessary to decide whether to lock editing. getCampaignDeadlines is also wrapped in React cache() so the call is deduped within a request. Not optimizing further.

[tokenbureau]

🎉 Deployment for commit f7ee8df :

Ingresses

• 🚀 https://egapro-feat-campaign-deadlines-gating-4vm55bx5.ovh.fabrique.social.gouv.fr/

Docker images

• 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/app:sha-f7ee8dfd716007ec4a22f7ca2f9cf5cf7404cac0

Debug

• 📕 Loki logs for namespace egapro-feat-campaign-deadlines-gating-4vm55bx5
• 📈 Pods monitoring for namespace egapro-feat-campaign-deadlines-gating-4vm55bx5
• 📈 Workloads monitoring for namespace egapro-feat-campaign-deadlines-gating-4vm55bx5
• 🐘 CNPG pg