fix(my-space): hide page size selector when table has 20 rows or fewer

[Viczei]

Summary

• Hide the « Nombre de lignes par page » selector in the my-space declarations table when the total number of rows is ≤ 20 (the option to change page size is irrelevant for small tables).
• Add a PAGE_SIZE_SELECTOR_THRESHOLD constant for the threshold.
• Update unit tests to cover both branches (selector hidden ≤ 20, visible > 20).

Closes #3156

Test plan

• pnpm test — 1062/1062 passed
• pnpm typecheck — 0 errors
• pnpm lint:check / pnpm format:check — clean
• Visual check on review env: small table (≤ 20 rows) hides the selector, large table (> 20 rows) shows it

[revu-bot]

Review Summary

The PR correctly implements the feature described in issue #3156: hiding the page-size selector when the table has ≤ 20 rows. The logic is straightforward and the tests cover both branches. A few issues worth addressing:

File	Lines	Severity	Issue
DeclarationsSection.tsx	~146	IMPORTANT	Threshold is off-by-one: > 20 hides selector at exactly 20 rows but the spec says "≤ 20 rows should hide it" — these are equivalent, but the constant name implies the boundary is inclusive, making > vs >= confusing
DeclarationsSection.tsx	~65–68	IMPORTANT	totalRows double-counts: it sums lengths of two already-filtered arrays instead of using declarations.length directly
DeclarationsSection.test.tsx	~155–165	IMPORTANT	Missing boundary test at exactly 20 rows — the "does not render" test uses only 3 rows (the default fixture), leaving the boundary value untested
DeclarationsSection.tsx	~146	MINOR	Selector is hidden but pageSize state still defaults to 10; if the table later grows past the threshold the first visible page size will be 10 regardless of what was previously selected — this is acceptable but worth noting

Overall the change is clean and well-scoped. The main actionable items are the boundary test gap and the totalRows calculation.

[tokenbureau]

🎉 Deployment for commit b2d4c24 :

Ingresses

• 🚀 https://egapro-fix-hide-page-size-selector-when-few-rows-1gy3y3al.ovh.fabrique.social.gouv.fr/

Docker images

• 📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/app:sha-b2d4c246173defa29e0d043e165c807e6664a071

Debug

• 📕 Loki logs for namespace egapro-fix-hide-page-size-selector-when-few-rows-1gy3y3al
• 📈 Pods monitoring for namespace egapro-fix-hide-page-size-selector-when-few-rows-1gy3y3al
• 📈 Workloads monitoring for namespace egapro-fix-hide-page-size-selector-when-few-rows-1gy3y3al
• 🐘 CNPG pg