fix(header): masquer le menu de navigation en mode connecté#3166
Merged
fix(header): masquer le menu de navigation en mode connecté#3166
Conversation
revu-bot
reviewed
Apr 8, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Review: Hide navigation menu in authenticated mode
This is a small, focused change that conditionally renders the <Navigation /> component based on session state. The logic is correct and aligns with issue #3157.
| File | Lines | Severity | Issue | Action |
|---|---|---|---|---|
MobileMenu.tsx |
52 | IMPORTANT | Navigation hidden only in mobile menu, not desktop nav bar | Verify desktop header also hides nav |
MobileMenu.tsx |
52 | IMPORTANT | No test coverage for the new conditional rendering | Add unit/integration tests |
Overall: The change is minimal and correct for the mobile menu path, but raises questions about consistency with the desktop layout and the absence of test coverage for a user-facing conditional.
revu-bot
reviewed
Apr 8, 2026
revu-bot
reviewed
Apr 8, 2026
Le sous-menu "Accueil" et "Observatoire" ne doit pas apparaître lorsque l'utilisateur est connecté. Closes #3157
LucasCharrier
approved these changes
Apr 8, 2026
maxgfr
approved these changes
Apr 8, 2026
|
🎉 Deployment for commit 2953628 : Docker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Closes #3157
Test plan