feat(admin): referent management (CRUD, import/export, public API) by LucasCharrier · Pull Request #3198 · SocialGouv/egapro

LucasCharrier · 2026-04-09T15:39:32Z

Summary

Add full referent management page in admin backoffice: paginated table with search (name, region, county), sortable columns, row selection, batch delete
Create/edit modals with DSFR form (region → county dependency, email/URL type toggle, substitute fields)
JSON import (replaces all data) and JSON/CSV export
Public API route GET /api/public/referents-egalite-professionnelle?format=json|csv
Admin sidebar navigation (Accueil, Référents)
Shared infrastructure: DsfrTable, useDsfrModal hook, regions/counties domain dictionaries

Based on feat/issue-3178-admin-role.

Note: Drizzle migration needs to be generated manually (pnpm db:generate) — drizzle-kit requires a TTY for interactive conflict resolution.

Quality gates

Generated with Claude Code

revu-bot

⚠️ PR Review Skipped

1 validation issue found. Review thresholds can be adjusted in .revu.yml.

See why it was skipped and detailed metrics

Issues Found

1. This PR changes 47 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

Total files changed: 47
Reviewable files: 47
Diff size: 3316 lines
Documentation files: 0
Largest file change: 280 lines
Addition/Deletion ratio: 417.71

This validation helps ensure the bot focuses on PRs where automated review provides the most value.

maxgfr

J'ai marqué pas mal de commentaires sur les autres PR, je pense il y a un soucis de rebase

- Create DsfrTable wrapper component in ~/modules/shared - Create shared useDsfrModal hook to deduplicate modal open/close logic - Export useZodForm from shared barrel for consistent imports - Add REGIONS, COUNTIES, REGIONS_TO_COUNTIES dictionaries to domain layer

- Create AdminNavigation component with DSFR sidemenu pattern - Update admin layout to include sidebar + content grid - Remove duplicate fr-container from AdminHomePage

…blic API - Add referents table to Drizzle schema with referent_type enum - Create adminReferents tRPC router (search, create, update, delete, import, exportAll) - Build AdminReferentsPage with paginated table, search, sort, batch delete - Add create/edit modals with region-dependent county select - Add JSON import modal with validation - Add JSON/CSV export buttons - Create public API route /api/public/referents-egalite-professionnelle - Add Zod schemas, types, constants for the referents module - Add unit tests for schemas, constants, and page component - Add E2E test for non-admin redirect Closes #3182

Server files imported shared constants through the `~/modules/shared` barrel, which also re-exports client-only hooks (useZodForm, useDsfrModal, useFileUploadForm). Turbopack pulled those hooks into the RSC bundle and failed on useRef/useForm. Import directly from uploadConfig instead.

The test assumed a non-admin logged-in user but Playwright shares a single AUTH_FILE (admin). Rewrite to follow admin-declarations.e2e.ts: happy-path admin access + unauthenticated redirect to /login.

Adds unit tests for all adminReferentsRouter procedures (search, create, update, delete, import, exportAll, auth guard) and for the public referents-egalite-professionnelle route (JSON default, CSV formatting and headers). Increases Sonar new-code coverage above the 60% gate.

…ort) Also fix lint errors: unused CountyCode import in ReferentFormFields, unused formatShortDate in DeclarationsSection, and replace the then-property in the router test mock with a Proxy to satisfy biome/noThenProperty.

Schema was pushed in CI via db:push but no migration file existed, so the table would not be created in envs that use db:migrate (prod/preprod). Add 0026_add_referents_table.sql with the referent_type enum, the app_referent table and the region index.

Without fr-btn--icon-left, DSFR treats the button as icon-only and hides the text, making the action unclear.

DSFR expects the `fr-icon-X` class to come before `fr-btn--icon-left`. When the modifier is placed before the icon class, some DSFR rules treat the button as icon-only and hide the text.

DSFR applies max-width:2rem;overflow:hidden to buttons with fr-icon-* inside a fr-btns-group unless the group itself has fr-btns-group--icon-left (or -right). Without this, the button text is visually hidden even when the button has fr-btn--icon-left.

Viczei · 2026-04-14T11:59:02Z

J'ai marqué pas mal de commentaires sur les autres PR, je pense il y a un soucis de rebase

Oui ca fait beaucoup de fichiers modifié pour une page de referents

LucasCharrier · 2026-04-14T12:37:59Z

J'ai marqué pas mal de commentaires sur les autres PR, je pense il y a un soucis de rebase

Oui ca fait beaucoup de fichiers modifié pour une page de referents

Le commentaire de Max c'était hier, mais normarlement là tout est bien rebase. C'est pas juste une page avec les referents, il y a un systeme de recherche, d'ajout, d'import de csv, il y la page d'admin et d'affichage publique. C'est vrai qu'il y a beaucoup de fichiers mais comme on subdivise tout en petit composants par fichier, ça fait rapidement plein de fichier au total.

Viczei · 2026-04-14T13:07:00Z

 CLAMAV_HOST="localhost"
 CLAMAV_PORT="3310"
 ADMIN_EMAILS="test@fia1.fr"
+EGAPRO_AUDIT_CLEANUP_TOKEN="change-me-to-a-32-chars-minimum-token"


Ah oui bien vu 👍

maxgfr · 2026-04-14T13:09:09Z

Pourquoi on met pas ça dans un router trpc ?

Le CSV bloque : tRPC renvoie du JSON enveloppé, pas moyen de setter Content-Disposition pour le téléchargement. Et pour un endpoint /api/public/ consommé par des clients externes (curl, Python, data.gouv), l'enveloppe tRPC + URL couplée au nom de procédure c'est pas le bon contrat. tRPC serait pertinent pour un usage interne.

maxgfr · 2026-04-14T13:18:08Z

 CLAMAV_HOST="localhost"
 CLAMAV_PORT="3310"
 ADMIN_EMAILS="test@fia1.fr"
+EGAPRO_AUDIT_CLEANUP_TOKEN="change-me-to-a-32-chars-minimum-token"


à quoi ca sert concretementt ? et pouquoi on l'a pas register dans le env.js ?

Ah ou alors, c'est une variable qu'on avait oublié d'ajouter :)

C'est juste bizarre d'avoir une variable clean_up comme ça, on pourra en discuter une next time

Oui c'est plus un oubli, c'est un token pour sécuriser l'api de nettoyage des logs d'audit

tokenbureau · 2026-04-16T08:16:06Z

🎉 Deployment for commit d8890a1 :

Ingresses

🚀 https://egapro-feat-issue-3182-admin-referents-7pnybwhn.ovh.fabrique.social.gouv.fr/

Docker images

📦 docker pull harbor.fabrique.social.gouv.fr/egapro/egapro/app:sha-d8890a12a17d99b0a33f780d9375d6ce5e9c0a5c

Debug

LucasCharrier requested review from a team as code owners April 9, 2026 15:39

revu-bot Bot requested a review from revu-bot April 9, 2026 15:39

revu-bot reviewed Apr 9, 2026

View reviewed changes

LucasCharrier changed the base branch from alpha to feat/issue-3178-admin-role April 9, 2026 15:41

Base automatically changed from feat/issue-3178-admin-role to alpha April 13, 2026 07:35

maxgfr reviewed Apr 13, 2026

View reviewed changes

LucasCharrier force-pushed the feat/issue-3182-admin-referents branch from 694a7b3 to 7cfa7c2 Compare April 13, 2026 14:42

LucasCharrier had a problem deploying to build-review-auto April 13, 2026 14:42 — with GitHub Actions Failure

LucasCharrier added 3 commits April 14, 2026 09:16

feat(admin): add sidebar navigation with Accueil and Référents links

5419e42

- Create AdminNavigation component with DSFR sidemenu pattern - Update admin layout to include sidebar + content grid - Remove duplicate fr-container from AdminHomePage

LucasCharrier force-pushed the feat/issue-3182-admin-referents branch from 7cfa7c2 to f159e73 Compare April 14, 2026 07:18

LucasCharrier had a problem deploying to build-review-auto April 14, 2026 07:18 — with GitHub Actions Failure

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 07:24 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 07:27 — with GitHub Actions Inactive

fix(e2e): rewrite admin-referents test to match actual auth setup

874ad90

The test assumed a non-admin logged-in user but Playwright shares a single AUTH_FILE (admin). Rewrite to follow admin-declarations.e2e.ts: happy-path admin access + unauthenticated redirect to /login.

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 07:48 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 07:50 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 08:09 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 08:11 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 08:24 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 08:26 — with GitHub Actions Inactive

LucasCharrier had a problem deploying to build-review-auto April 14, 2026 09:05 — with GitHub Actions Error

docs(env): add EGAPRO_AUDIT_CLEANUP_TOKEN placeholder to .env.example

4da9364

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 09:07 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 09:10 — with GitHub Actions Inactive

fix(admin): show Modifier text next to edit icon in referent table

ab21b82

Without fr-btn--icon-left, DSFR treats the button as icon-only and hides the text, making the action unclear.

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 09:15 — with GitHub Actions Inactive

LucasCharrier had a problem deploying to review-auto April 14, 2026 09:18 — with GitHub Actions Error

fix(admin): reorder icon classes so DSFR renders text next to icons

4ad5f36

DSFR expects the `fr-icon-X` class to come before `fr-btn--icon-left`. When the modifier is placed before the icon class, some DSFR rules treat the button as icon-only and hide the text.

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 09:21 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 09:25 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to build-review-auto April 14, 2026 09:34 — with GitHub Actions Inactive

LucasCharrier temporarily deployed to review-auto April 14, 2026 09:37 — with GitHub Actions Inactive

Viczei approved these changes Apr 14, 2026

View reviewed changes

Viczei reviewed Apr 14, 2026

View reviewed changes

maxgfr reviewed Apr 14, 2026

View reviewed changes

maxgfr approved these changes Apr 14, 2026

View reviewed changes

Merge branch 'alpha' into feat/issue-3182-admin-referents

d8890a1

LucasCharrier temporarily deployed to build-review-auto April 16, 2026 08:09 — with GitHub Actions Inactive

LucasCharrier enabled auto-merge (squash) April 16, 2026 08:09

LucasCharrier temporarily deployed to review-auto April 16, 2026 08:13 — with GitHub Actions Inactive

LucasCharrier merged commit 0a889e8 into alpha Apr 16, 2026
15 checks passed

LucasCharrier deleted the feat/issue-3182-admin-referents branch April 16, 2026 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(admin): referent management (CRUD, import/export, public API)#3198

feat(admin): referent management (CRUD, import/export, public API)#3198
LucasCharrier merged 13 commits intoalphafrom
feat/issue-3182-admin-referents

LucasCharrier commented Apr 9, 2026

Uh oh!

revu-bot left a comment

Uh oh!

maxgfr left a comment

Uh oh!

Viczei commented Apr 14, 2026

Uh oh!

LucasCharrier commented Apr 14, 2026

Uh oh!

Viczei Apr 14, 2026

Uh oh!

maxgfr Apr 14, 2026

Uh oh!

LucasCharrier Apr 16, 2026

Uh oh!

maxgfr Apr 14, 2026

Uh oh!

maxgfr Apr 14, 2026

Uh oh!

maxgfr Apr 14, 2026

Uh oh!

Viczei Apr 14, 2026

Uh oh!

tokenbureau Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LucasCharrier commented Apr 9, 2026

Summary

Quality gates

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

⚠️ PR Review Skipped

Issues Found

PR Metrics

Uh oh!

maxgfr left a comment

Choose a reason for hiding this comment

Uh oh!

Viczei commented Apr 14, 2026

Uh oh!

LucasCharrier commented Apr 14, 2026

Uh oh!

Viczei Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

maxgfr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

LucasCharrier Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

maxgfr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

maxgfr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

maxgfr Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Viczei Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

tokenbureau Bot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants