Skip to content

feat: set a warning message on forbidden pages instead of blocking#436

Merged
Viczei merged 5 commits intomasterfrom
fix-maj-mt-forbidden
Jun 23, 2025
Merged

feat: set a warning message on forbidden pages instead of blocking#436
Viczei merged 5 commits intomasterfrom
fix-maj-mt-forbidden

Conversation

@Viczei
Copy link
Copy Markdown
Contributor

@Viczei Viczei commented Jun 23, 2025

No description provided.

@Viczei Viczei requested a review from maxgfr June 23, 2025 08:17
@Viczei Viczei self-assigned this Jun 23, 2025
@Viczei Viczei changed the title feat: set a warning message on forbidden pages instead of blocking up… feat: set a warning message on forbidden pages instead of blocking Jun 23, 2025
Copy link
Copy Markdown
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut manuellement modifier le https://github.com/SocialGouv/fiches-travail-data/blob/master/data/fiches-travail.json

Le fait qu'on ait mis le Promise.reject était pour notifié le fait qu'il y a des erreurs dessus

Comment thread .github/workflows/release.yml Outdated
La mise à jour du dépôt fiches-travail-data a échoué.
La mise à jour du dépôt fiches-travail-data a échoué.
[Les logs sont disponibles ici](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
COLOR: "#FF0000"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +72 to +74
FORBIDDEN_CONTENT="${FORBIDDEN_CONTENT//'%'/'%25'}"
FORBIDDEN_CONTENT="${FORBIDDEN_CONTENT//$'\n'/'%0A'}"
FORBIDDEN_CONTENT="${FORBIDDEN_CONTENT//$'\r'/'%0D'}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@Viczei Viczei merged commit c4bcde0 into master Jun 23, 2025
3 checks passed
@Viczei Viczei deleted the fix-maj-mt-forbidden branch June 23, 2025 10:11
github-actions Bot pushed a commit that referenced this pull request Jun 23, 2025
# [4.917.0](v4.916.0...v4.917.0) (2025-06-23)

### Features

* **data:** 20250623_2115 update ([f69bb68](f69bb68))
* set a warning message on forbidden pages instead of blocking ([#436](#436)) ([c4bcde0](c4bcde0))
@tokenbureau
Copy link
Copy Markdown

tokenbureau Bot commented Jun 23, 2025

🎉 This PR is included in version 4.917.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau Bot added the released label Jun 23, 2025
@Viczei Viczei linked an issue Jul 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug mise à jour fiche MT

2 participants