feat: ajout du dockerfile pour l'init de la database#1283
Open
marccyprien wants to merge 3 commits intomainfrom
Open
feat: ajout du dockerfile pour l'init de la database#1283marccyprien wants to merge 3 commits intomainfrom
marccyprien wants to merge 3 commits intomainfrom
Conversation
revu-bot
reviewed
Apr 21, 2026
Collaborator
revu-bot
left a comment
There was a problem hiding this comment.
Review Summary
This PR introduces a Dockerfile for database initialization and a GitHub Actions workflow to build and push the resulting image to GHCR.
| File | Lines | Severity | Issue |
|---|---|---|---|
.github/workflows/build-database-init.yaml |
6 | CRITICAL | Workflow only triggers on a feature branch — will never run on main |
.github/workflows/build-database-init.yaml |
38–41 | IMPORTANT | latest tag logic is broken because the default branch is never in the trigger |
.github/workflows/build-database-init.yaml |
14 | IMPORTANT | IMAGE_NAME uses the full repo name, producing a wrong/ambiguous image path for a sub-image |
Dockerfile-database-init |
1 | IMPORTANT | Base image pinned to a floating major tag — no digest pinning, reproducibility risk |
Dockerfile-database-init |
3–5 | IMPORTANT | Entire pg/ directory is copied into the image; sensitive files (credentials, configs) may be leaked |
revu-bot
reviewed
Apr 21, 2026
revu-bot
reviewed
Apr 21, 2026
revu-bot
reviewed
Apr 21, 2026
revu-bot
reviewed
Apr 21, 2026
revu-bot
reviewed
Apr 21, 2026
d345c8e to
c4781e9
Compare
c4781e9 to
1d517dc
Compare
Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr>
|
|
🎉 Deployment for commit 6299d99 : Ingresses
Docker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.