Skip to content

chore: cleanup ts / tests#1326

Merged
achorein merged 1 commit into
mainfrom
chore/cleanup-ts-test
May 19, 2026
Merged

chore: cleanup ts / tests#1326
achorein merged 1 commit into
mainfrom
chore/cleanup-ts-test

Conversation

@achorein

Copy link
Copy Markdown
Collaborator

Ticket(s) lié(s)

Description

Screenshot / liens loom

Check-list

  • Ma branche est rebase sur main
  • Des tests ont été écrits pour tous les endpoints créés ou modifiés
  • Refacto "à la volée" des parties sur lesquelles j'ai codée
  • Plus de console.log
  • J'ai ajouté une validation de schéma sur la route que j'ai ajouté ou modifié
  • J'ai converti les fichiers vue en <script lang="ts">
  • Mon code est en Typescript (autant que possible)

Testing instructions

@achorein achorein self-assigned this May 12, 2026
@revu-bot revu-bot Bot requested a review from revu-bot May 12, 2026 15:36

@revu-bot revu-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ PR Review Skipped

1 validation issue found. Review thresholds can be adjusted in .revu.yml.

See why it was skipped and detailed metrics

Issues Found

1. This PR changes 246 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 246
  • Reviewable files: 246
  • Diff size: 6181 lines
  • Documentation files: 0
  • Largest file change: 779 lines
  • Addition/Deletion ratio: 1.04

This validation helps ensure the bot focuses on PRs where automated review provides the most value.

@socket-security

socket-security Bot commented May 12, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@achorein achorein force-pushed the chore/cleanup-ts-test branch from fe28701 to 986b5e8 Compare May 13, 2026 08:34
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 08:34 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from 986b5e8 to ad9ad1e Compare May 13, 2026 09:56
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 09:56 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from ad9ad1e to ea09f1d Compare May 13, 2026 12:25
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 12:25 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 12:25 — with GitHub Actions Inactive
@achorein achorein had a problem deploying to build-review-auto May 13, 2026 12:25 — with GitHub Actions Failure
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 12:25 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 12:25 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 12:25 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from ea09f1d to 4d842c6 Compare May 13, 2026 13:19
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 13:19 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 14:40 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 14:40 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from eb3fa74 to 8891144 Compare May 13, 2026 16:37
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 16:37 — with GitHub Actions Inactive
@achorein achorein had a problem deploying to build-review-auto May 13, 2026 16:37 — with GitHub Actions Failure
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 16:37 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 16:37 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 16:37 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 13, 2026 16:37 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from 8891144 to 0ac3c91 Compare May 18, 2026 08:38
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 08:38 — with GitHub Actions Inactive
@achorein achorein force-pushed the chore/cleanup-ts-test branch from 0ac3c91 to b5c6604 Compare May 18, 2026 13:53
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto May 18, 2026 13:54 — with GitHub Actions Inactive
@sonarqubecloud

Copy link
Copy Markdown

@tokenbureau

tokenbureau Bot commented May 18, 2026

Copy link
Copy Markdown

🎉 Deployment for commit b5c6604 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/backend:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/cron:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/external-api:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-bo:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-usagers:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/migrations:sha-b5c660467f659366ff9a0057bb6d8307d35fb98a
  • 📦 docker pull maildev/maildev:2.1.0
Debug

@achorein achorein merged commit ae9901e into main May 19, 2026
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants