finalize tier 1 reachability scans #135
Merged
+119
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… associated with the tier 1 analytics
mtorp
requested review from
jhiesey and
mikolalysenko
and removed request for
a team
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.40.dev1Docker image: |
…g up pre commit environment
…nstead of after the diff scan. This way if the diff scan fails for some reason the reachability status is still updated.
dacoburn
approved these changes
Nov 27, 2025
Collaborator
dacoburn
left a comment
dacoburn
left a comment
There was a problem hiding this comment.
Moved the finalize logic to after the Full Scan Creation. That way if the diff logic fails for some reason we still finalize the reachability state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SDK function
finalize_tier1for associating Tier 1 reachability analytics, which is gathered while the Tier 1 analysis is running, with the full scan that is created after the reachability analysis is complete.The SDK function is added in SocketDev/socket-sdk-python#58. The SDK PR must be merged and deployed before this PR is merged.
Why?
It helps the Socket team debug potential issues in the reachability analysis.
Public Changelog
N/A