Merge dev into main. Integrate latest bug fixes and improvements. #1643
7 new issues (0 max.) of at least minor severity.
Issues
======
- Added 7
Complexity increasing per file
==============================
- Servers/UI/OJS.Servers.Ui/Program.cs 1
- Servers/Infrastructure/OJS.Servers.Infrastructure/Extensions/WebApplicationExtensions.cs 5
- Servers/Infrastructure/OJS.Servers.Infrastructure/Extensions/ServiceCollectionExtensions.cs 2
- Servers/Worker/OJS.Servers.Worker/Program.cs 2
- Services/Common/OJS.Services.Common/Implementations/PublisherService.cs 3
- Servers/UI/OJS.Servers.Ui/Consumers/ExecutionResultConsumer.cs 2
- Servers/Worker/OJS.Servers.Worker/Consumers/SubmissionsForProcessingConsumer.cs 12
- Servers/Administration/OJS.Servers.Administration/Consumers/RetestSubmissionConsumer.cs 2
- Services/Common/OJS.Services.Common.Data/Pagination/FilteringService.cs 1
- Services/Worker/OJS.Services.Worker.Business/Implementations/ExecutionStrategyFactory.cs 1
- Services/Worker/OJS.Services.Worker.Business/Implementations/ExecutionStrategySettingsProvider.cs 1
- Servers/UI/OJS.Servers.Ui/ClientApp/src/pages/administration-new/contests/AdministrationContests.tsx 1
- Servers/UI/OJS.Servers.Ui/ClientApp/src/pages/administration-new/tests/testsGridColumns.tsx 3
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/Helpers/JsCodePreEvaluationCodeProvider.cs 1
- Servers/UI/OJS.Servers.Ui/Controllers/CompeteController.cs 1
- Servers/UI/OJS.Servers.Ui/Consumers/SubmissionStartedProcessingConsumer.cs 2
- Servers/UI/OJS.Servers.Ui/Consumers/ExecutionResultErrorConsumer.cs 4
- Services/Common/OJS.Services.Common.Data/Implementations/SubmissionsCommonBusinessService.cs 5
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/NodeJs/NodeJsPreprocessExecuteAndRunAllUnitTestsWithMochaExecutionStrategy.cs 5
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/Eslint/EslintError.cs 1
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/Eslint/EslintMessage.cs 1
- Servers/Infrastructure/OJS.Servers.Infrastructure/Extensions/WebApplicationBuilderExtensions.cs 5
- Services/Common/OJS.Services.Common/Telemetry/OjsActivitySources.cs 1
- Servers/Infrastructure/OJS.Servers.Infrastructure/Middleware/CorrelationIdMiddleware.cs 5
- Services/Common/OJS.Services.Common/Telemetry/ITracingService.cs 1
- Services/Common/OJS.Services.Common/Telemetry/TracingService.cs 9
- Services/Common/OJS.Services.Common/Telemetry/SimpleTracePropagation.cs 4
Complexity decreasing per file
==============================
+ Services/Infrastructure/OJS.Services.Infrastructure/Configurations/ApplicationConfig.cs -1
+ Servers/UI/OJS.Servers.Ui/ClientApp/src/components/administration/submission-type-documents/AdministrationSubmissionTypeDocumentPage.tsx -2
+ Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/NodeJs/Typescript/TypeScriptPreprocessExecuteAndRunUnitTestsWithMochaExecutionStrategy.cs -2
Clones added
============
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/RunSpaAndExecuteMochaTestsExecutionStrategy.cs 1
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/RunSpaAndExecuteMochaTestsExecutionStrategySeparateTests.cs 1
- Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/NodeJs/NodeJsPreprocessExecuteAndRunAllUnitTestsWithMochaExecutionStrategy.cs 6
- Services/Common/OJS.Services.Common/Telemetry/ITracingService.cs 2
- Services/Common/OJS.Services.Common/Telemetry/TracingService.cs 14
Clones removed
==============
+ Servers/UI/OJS.Servers.Ui/ClientApp/src/pages/contest-results/ContestResultsPage.tsx -2
+ Services/Common/OJS.Workers/OJS.Workers.ExecutionStrategies/NodeJs/Typescript/TypeScriptPreprocessExecuteAndRunUnitTestsWithMochaExecutionStrategy.cs -4
See the complete overview on Codacy
Annotations
Check warning on line 1 in Docker/worker_base/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/Dockerfile#L1
Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag
Check warning on line 9 in Docker/worker_base/dotnet/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/dotnet/Dockerfile#L9
Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Check notice on line 25 in Docker/worker_base/dotnet/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/dotnet/Dockerfile#L25
Avoid additional packages by specifying `--no-install-recommends`
Check warning on line 25 in Docker/worker_base/dotnet/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/dotnet/Dockerfile#L25
Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Check warning on line 46 in Docker/worker_base/dotnet/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/dotnet/Dockerfile#L46
Use WORKDIR to switch to a directory
Check warning on line 50 in Docker/worker_base/dotnet/Dockerfile
codacy-production / Codacy Static Code Analysis
Docker/worker_base/dotnet/Dockerfile#L50
Use WORKDIR to switch to a directory
Check notice on line 43 in Services/Common/OJS.Services.Common/Implementations/PublisherService.cs
codacy-production / Codacy Static Code Analysis
Services/Common/OJS.Services.Common/Implementations/PublisherService.cs#L43
Remove this redundant jump.