Skip to content

Converted Sigrid panel from WebviewPanel to WebviewView#14

Merged
dennis-sig merged 6 commits into
mainfrom
sigrid-panel-view
Mar 31, 2026
Merged

Converted Sigrid panel from WebviewPanel to WebviewView#14
dennis-sig merged 6 commits into
mainfrom
sigrid-panel-view

Conversation

@andrtolv

Copy link
Copy Markdown
Contributor

Converted Sigrid panel from WebviewPanel to WebviewView.
Added Sigrid item to the statusbar to open / focus Sigrid panel (useful, when the panel is completely hidden).
Sending active editor path to the webview on init for proper Active filter behavior on showing/hiding the panel.

image

Andrius Tolvaišis added 4 commits March 26, 2026 18:01
PoC: Example of tree view panel.
Add icon for the `sigridFindingsPanel`.
Remove tree view experimental functionality.
Refactor active editor message handling.
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-03-25.

👍 What went well?

You fixed or improved 2 refactoring candidates.

Risk System property Location
🟡 Unit Size
(Fixed)
src/panels/sigrid-panel.ts
SigridPanel.render(Uri)
🟡 Unit Size
(Fixed)
src/panels/sigrid-panel.ts
SigridPanel.getWebviewContent(Webview,Uri)

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk System property Location
🟡 Unit Size
(Introduced)
src/panels/sigrid-panel.ts
SigridPanel.getWebviewContent(Webview)

📚 Remaining technical debt

1 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-03-25 Before changes New/changed code
Volume 5.5 N/A N/A
Duplication 5.2 5.5 5.5
Unit Size 4.4 3.9 4.6
Unit Complexity 3.6 5.5 5.5
Unit Interfacing 4.3 4.5 4.5
Module Coupling 5.4 5.5 5.5
Component Independence 3.3 N/A N/A
Component Entanglement 4.0 N/A N/A
Maintainability 4.5 5.1 5.2

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Sigrid Open Source Health feedback

❌️ You failed to meet your objective of having no open source vulnerabilities.

✅ You achieved your objective of having no open source libraries with license issues.

Show details

Sigrid compared your code against the baseline of 2026-03-25.

  • ❌ means the library has issues that fail your objective.
  • ⚠️ means the library has issues, but they are not severe enough to fail your objective.
  • ✅ means everything is fine.

If you believe these findings are false positives, you can
exclude them in the Sigrid configuration.

👎 What could be better?

You have 2 open source libraries with issues.

Vulnerabilities License Library Latest version Location(s)
@angular:core 21.0.8
GHSA-g93w-mfhg-p222, GHSA-prjf-86w9-mfqv.
21.2.6 sigrid-ext-app/package-lock.json
@angular:compiler 21.0.8
GHSA-g93w-mfhg-p222.
21.2.6 sigrid-ext-app/package-lock.json

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@andrtolv andrtolv mentioned this pull request Mar 30, 2026
@dennis-sig dennis-sig self-requested a review March 31, 2026 06:24
@dennis-sig dennis-sig merged commit 6a7b523 into main Mar 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants