Skip to content

Subsystem support#16

Merged
dennis-sig merged 8 commits into
mainfrom
11-subsystem-support
Apr 7, 2026
Merged

Subsystem support#16
dennis-sig merged 8 commits into
mainfrom
11-subsystem-support

Conversation

@andrtolv

@andrtolv andrtolv commented Apr 7, 2026

Copy link
Copy Markdown
Contributor
  • Added a new configuration setting Subsystem (sigrid-vscode.subsystem).
  • Added filtering and path normalization based on subsystem setting.
    Scoping on Component? #11

@andrtolv andrtolv self-assigned this Apr 7, 2026
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-04-07.

👍 What went well?

You fixed or improved 8 refactoring candidates.

Risk System property Location
🟠 Unit Size
(Fixed)
sigrid-ext-app/src/app/mappers/open-source-health-mapper.ts
OpenSourceHealthMapper.map(OpenSourceHealthResponse)
🟠 Unit Complexity
(Fixed)
sigrid-ext-app/src/app/mappers/security-finding-mapper.ts
SecurityFindingMapper.map(SecurityFindingResponse[])
🟠 Unit Complexity
(Fixed)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.getFileLocations(RefactoringCategory,RefactoringCandidateResponse)
🟠 Unit Complexity
(Fixed)
sigrid-ext-app/src/app/mappers/open-source-health-mapper.ts
OpenSourceHealthMapper.map(OpenSourceHealthResponse)
🟡 Unit Size
(Fixed)
sigrid-ext-app/src/app/mappers/security-finding-mapper.ts
SecurityFindingMapper.map(SecurityFindingResponse[])
🟡 Unit Size
(Fixed)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.getFileLocations(RefactoringCategory,RefactoringCandidateResponse)
🟡 Unit Size
(Fixed)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.mapRefactoringCandidate(RefactoringCategory,RefactoringCandidatesResponse)
🟡 Unit Complexity
(Fixed)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.mapRefactoringCandidate(RefactoringCategory,RefactoringCandidatesResponse)

👎 What could be better?

Unfortunately, 18 refactoring candidates were introduced or got worse.

Risk System property Location
🟠 Unit Complexity
(Introduced)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.getFileLocations(RefactoringCategory,RefactoringCandidateResponse,string)
🟠 Unit Interfacing
(Worsened)
[sigrid-ext-app/src/app/services/sigrid-data.ts
SigridData.fetchFindings(Observable,WritableSignal<SigridFinding<Finding>
🟡 Unit Size
(Introduced)
sigrid-ext-app/src/app/mappers/open-source-health-mapper.ts
OpenSourceHealthMapper.createOshDependency(any,string)
🟡 Unit Size
(Introduced)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.createRefactoringCandidate(RefactoringCategory,RefactoringCandidateResponse,string)
🟡 Unit Size
(Worsened)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.getDescription(RefactoringCategory,RefactoringCandidateResponse)
🟡 Unit Size
(Introduced)
sigrid-ext-app/src/app/mappers/refactoring-candidate-mapper.ts
RefactoringCandidateMapper.getFileLocations(RefactoringCategory,RefactoringCandidateResponse,string)
🟡 Unit Size
(Introduced)
sigrid-ext-app/src/app/mappers/security-finding-mapper.ts
SecurityFindingMapper.createSecurityFinding(SecurityFindingResponse,string)
🟡 Unit Size
(Worsened)
[sigrid-ext-app/src/app/services/sigrid-data.ts
SigridData.fetchFindings(Observable,WritableSignal<SigridFinding<Finding>
⚫️ + 10 more

📚 Remaining technical debt

7 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-04-07 Before changes New/changed code
Volume 5.5 N/A N/A
Duplication 5.2 5.5 5.5
Unit Size 4.4 2.5 3.2
Unit Complexity 3.6 1.8 2.2
Unit Interfacing 4.3 2.4 2.4
Module Coupling 5.5 5.5 4.3
Component Independence 3.5 N/A N/A
Component Entanglement 4.0 N/A N/A
Maintainability 4.5 3.6 3.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Sigrid Open Source Health feedback

✅ You achieved your objective of having no open source vulnerabilities.

✅ You achieved your objective of having no open source libraries with license issues.

Show details

Sigrid compared your code against the baseline of 2026-04-07.

  • ❌ means the library has issues that fail your objective.
  • ⚠️ means the library has issues, but they are not severe enough to fail your objective.
  • ✅ means everything is fine.

If you believe these findings are false positives, you can
exclude them in the Sigrid configuration.

👍 What went well?

You updated 2 open source libraries that previously had issues.

Vulnerabilities License Library Latest version Location(s)
@angular:compiler 21.0.8
CVE-2026-32635.
21.2.7 sigrid-ext-app/package-lock.json
@angular:core 21.0.8
CVE-2026-32635, CVE-2026-27970.
21.2.7 sigrid-ext-app/package-lock.json

View this system in Sigrid

Sigrid Security feedback (Beta)

✅ You achieved your objective of having no high-severity security findings

Show details

Sigrid CI for Security is currently in Beta. The documentation contains more information on its current state and known limitations.

Sigrid compared your code against the baseline of 2026-04-07 11:41 UTC.

👍 What went well?

You fixed 0 security findings.

👎 What could be better?

You did not introduce any security findings during your changes, great job!

😑 You have remaining security findings

You have 1 open security findings.
You can view these findings in Sigrid.


View this system in Sigrid

Andrius Tolvaišis added 2 commits April 7, 2026 15:03
@dennis-sig dennis-sig self-requested a review April 7, 2026 12:37
@dennis-sig dennis-sig merged commit c93e600 into main Apr 7, 2026
2 checks passed
@dennis-sig dennis-sig mentioned this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants