Skip to content

Filtering findings#18

Merged
andrtolv merged 9 commits into
mainfrom
filtering-findings
May 18, 2026
Merged

Filtering findings#18
andrtolv merged 9 commits into
mainfrom
filtering-findings

Conversation

@is-yu

@is-yu is-yu commented Apr 30, 2026

Copy link
Copy Markdown

No description provided.

@is-yu is-yu self-assigned this Apr 30, 2026
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-05-14.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 5 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
sigrid-ext-app/src/app/open-source-health/open-source-health.ts line 18-23
sigrid-ext-app/src/app/security/security.ts line 21-26
🟠 Unit Interfacing
(Worsened)
[src/commands/create-jira-issue-command.ts
CreateJiraIssueCommand.callJiraApi(string,string,string,string,object
🟡 Unit Size
(Worsened)
[src/commands/create-jira-issue-command.ts
CreateJiraIssueCommand.callJiraApi(string,string,string,string,object
🟡 Unit Size
(Introduced)
sigrid-ext-app/src/app/shared/filterable-header/filterable-header.ts
FilterableHeader.openDropdown()
🟡 Unit Interfacing
(Introduced)
sigrid-ext-app/src/app/services/finding-filter.ts
FindingFilterService.setColumnFilter(string,string,any)

📚 Remaining technical debt

5 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-05-14 Before changes New/changed code
Volume N/A N/A N/A
Duplication 4.9 5.5 4.7
Unit Size 4.2 3.5 3.9
Unit Complexity 3.9 3.8 4.1
Unit Interfacing 3.9 3.2 3.8
Module Coupling 5.2 5.5 5.5
Component Independence 3.5 N/A N/A
Component Entanglement 4.1 N/A N/A
Maintainability 4.2 4.3 4.4

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Sigrid Open Source Health feedback

✅ You achieved your objective of having no open source vulnerabilities.

✅ You achieved your objective of having no open source libraries with license issues.

Show details

Sigrid compared your code against the baseline of 2026-05-14.


View this system in Sigrid

Sigrid Security feedback (Beta)

✅ You achieved your objective of having no high-severity security findings

Show details

Sigrid CI for Security is currently in Beta. The documentation contains more information on its current state and known limitations.

Sigrid compared your code against the baseline of 2026-05-14 09:30 UTC.

👍 What went well?

You did not introduce any security findings during your changes, great job!

😑 You have remaining security findings

You have 1 open security findings.
You can view these findings in Sigrid.


View this system in Sigrid

Yu Huang and others added 8 commits April 30, 2026 10:25
# Conflicts:
#	sigrid-ext-app/src/app/app.ts
#	sigrid-ext-app/src/app/commands/configuration-changed-command.spec.ts
#	sigrid-ext-app/src/app/commands/initialize-command.spec.ts
#	sigrid-ext-app/src/app/maintainability/maintainability.html
#	sigrid-ext-app/src/app/maintainability/maintainability.ts
#	sigrid-ext-app/src/app/open-source-health/open-source-health.html
#	sigrid-ext-app/src/app/open-source-health/open-source-health.ts
#	sigrid-ext-app/src/app/security/security.html
#	sigrid-ext-app/src/app/security/security.ts
#	sigrid-ext-app/src/app/services/finding-selection.spec.ts
#	sigrid-ext-app/src/app/services/sigrid-configuration.spec.ts
…ce reusable `pascalCaseToTitleCase` function, and enhance risk filtering with customizable label and sorting options.
…ce reusable `pascalCaseToTitleCase` function, and enhance risk filtering with customizable label and sorting options.
@andrtolv andrtolv merged commit 967c0a3 into main May 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants