Smooth weekly pace gap#1120
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe2410e1ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fe2410e to
c477d6a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Closes #999
Verification
uv run ruff check app/modules/dashboard/weekly_pace.py app/modules/settings app/modules/dashboard/service.py app/modules/dashboard/schemas.py app/db/models.py tests/integration/test_dashboard_overview.py tests/integration/test_settings_api.pyuv run pytest tests/integration/test_dashboard_overview.py::test_dashboard_projections_weekly_credit_pace_forecast_uses_recent_slope_not_full_window_average tests/integration/test_dashboard_overview.py::test_dashboard_projections_weekly_credit_pace_smooths_displayed_gap tests/integration/test_dashboard_overview.py::test_dashboard_projections_weekly_credit_pace_uses_configured_working_days tests/integration/test_settings_api.py::test_settings_api_get_and_update tests/integration/test_settings_api.py::test_settings_api_rejects_invalid_weekly_pace_smoothing_minutes -qbun run test -- src/features/settings/schemas.test.ts src/features/settings/components/routing-settings.test.tsx src/features/dashboard/components/weekly-credits-pace-card.test.tsx src/features/dashboard/utils.test.tsbun run lint -- src/features/settings/schemas.ts src/features/settings/payload.ts src/features/settings/components/routing-settings.tsx src/features/settings/components/routing-settings.test.tsx src/features/dashboard/schemas.ts src/features/dashboard/utils.ts src/features/dashboard/components/weekly-credits-pace-card.tsx src/features/dashboard/components/weekly-credits-pace-card.test.tsx src/features/dashboard/utils.test.ts src/test/mocks/factories.tsmake migration-checkopenspec validate smooth-weekly-pace-gap --strict