Skip to content

fix(types): clear existing ty diagnostics#517

Merged
Soju06 merged 1 commit into
Soju06:mainfrom
Komzpa:codex/fix-ty-diagnostics
May 1, 2026
Merged

fix(types): clear existing ty diagnostics#517
Soju06 merged 1 commit into
Soju06:mainfrom
Komzpa:codex/fix-ty-diagnostics

Conversation

@Komzpa

@Komzpa Komzpa commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • clean up the existing ty check diagnostics on main
  • keep Pydantic builder code on snake_case field names via model_validate instead of alias-only constructor kwargs
  • make test-only invalid assignments, partial fake repositories, and recursive JSON payloads explicit to the type checker

Validation

  • .venv/bin/ty check
  • .venv/bin/ruff check .
  • .venv/bin/ruff format --check .
  • .venv/bin/pytest -q tests/unit tests/test_request_logs_options_api.py (1429 passed, 39 skipped)
  • .venv/bin/pytest -q tests/integration/test_db_models.py tests/integration/test_migrations.py tests/integration/test_v1_models.py tests/integration/test_v1_usage.py (36 passed, 3 skipped)

@Komzpa Komzpa force-pushed the codex/fix-ty-diagnostics branch from 63e1bb8 to eef4190 Compare April 29, 2026 11:16
@Komzpa Komzpa marked this pull request as ready for review April 29, 2026 11:16
@Soju06

Soju06 commented May 1, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 merged commit 0cd5d4e into Soju06:main May 1, 2026
18 checks passed
@Soju06

Soju06 commented May 1, 2026

Copy link
Copy Markdown
Owner

@all-contributors please add @Komzpa for code

@allcontributors

Copy link
Copy Markdown
Contributor

@Soju06

I've put up a pull request to add @Komzpa! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants