feat(accounts): add compact quota row display toggle#539
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35f8597942
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hi @cani1989 — thanks for the contribution! Just a heads up: PR #562 ( I think we can close this one. Let me know if you'd like to salvage anything specific from your version first. |
|
@Soju06 Great - Can I be added as contributor as well? |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b86fd4bbb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| target.id_token_encrypted = source.id_token_encrypted | ||
| target.last_refresh = source.last_refresh | ||
| target.status = source.status | ||
| target.priority = source.priority |
There was a problem hiding this comment.
Updating an existing account via import or OAuth currently overwrites any manually assigned priority because _apply_account_updates always copies source.priority into the persisted row. Both AccountsService.import_account and OauthService construct source accounts with priority=AccountPriority.SILVER, so a user who sets an account to gold/bronze will lose that setting on the next re-import/reauth. This breaks priority routing behavior and makes priority updates non-durable.
Useful? React with 👍 / 👎.
Komzpa
added
🤖 codex: needs work
|
Maintainer cleanup: closing this as stale / no longer merge-ready against the current This PR has been open across substantial main-branch churn and is currently carrying at least one stale signal (conflicts/blocked or failing checks, outstanding If the change is still needed, please open a fresh, focused PR rebased on current |
Komzpa
added
the
superseded
3 participants
Summary
5H,W, andBoth, defaulting toBothFixes #520
Validation
CI=1 ./node_modules/.bin/vitest run --reporter=dot src/features/settings/components/appearance-settings.test.tsx src/features/accounts/components/account-list-item.test.tsx src/hooks/use-account-quota-display.test.ts./node_modules/.bin/eslint src/features/settings/components/appearance-settings.tsx src/features/settings/components/appearance-settings.test.tsx src/features/accounts/components/account-list-item.tsx src/features/accounts/components/account-list-item.test.tsx src/hooks/use-account-quota-display.ts src/hooks/use-account-quota-display.test.tsgit diff --checkcodex-lb-devrebuilt from commit35f8597and health checked