Skip to content

feat(accounts): export OpenCode auth json#757

Merged
Soju06 merged 6 commits into
Soju06:mainfrom
Komzpa:revive/pr-532
May 27, 2026
Merged

feat(accounts): export OpenCode auth json#757
Soju06 merged 6 commits into
Soju06:mainfrom
Komzpa:revive/pr-532

Conversation

@Komzpa

@Komzpa Komzpa commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Revives #532 on a maintainer-owned branch because the original PR head has maintainerCanModify=false.

Credit: original implementation by @lNimien in #532; this branch rebases and updates that work on current main.

  • Adds OpenCode auth JSON export flow for accounts.
  • Fixes the known review blocker by exporting chatgpt_account_id directly, so unknown real ChatGPT account ids serialize as null instead of falling back to the local codex-lb account id.

Validation

  • ruff check app/modules/accounts app/core/auth tests/integration/test_account_opencode_auth_export.py passed
  • ruff format --check app/modules/accounts app/core/auth tests/integration/test_account_opencode_auth_export.py passed
  • git diff --check origin/main...HEAD passed
  • pytest tests/integration/test_account_opencode_auth_export.py was blocked in this isolated worktree because no .venv exists and system pytest is missing pydantic_settings
  • ty check ... was blocked because ty is not installed on PATH and no .venv/bin/ty exists

OpenSpec

  • OpenCode auth export requirements remain included and updated.

Revives #532

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42f8cc818d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/modules/accounts/api.py
Comment thread .github/workflows/docker.yml Outdated
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
Comment thread .github/workflows/docker.yml Outdated
@lNimien

lNimien commented May 21, 2026

Copy link
Copy Markdown

Hey, thanks for reviving this PR.

Sorry I was offline for about a week due to holidays, so I couldn’t respond earlier on #532. I’ve now enabled “Allow edits by maintainers” for future PRs.

Since #757 is based on my original implementation from #532, could you please keep the attribution/authorship clear in the final merge? I’m also happy to review this PR or help with any remaining fixes.

@Soju06

Soju06 commented May 21, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Komzpa Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Komzpa Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Komzpa Komzpa removed the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Soju06 Soju06 added the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Soju06 Soju06 removed the 🤖 codex: needs work [@codex review] raised an issue label May 21, 2026
@Soju06

Soju06 commented May 21, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: ok [@codex review] says no issues found. labels May 21, 2026
@Soju06

Soju06 commented May 24, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: ok [@codex review] says no issues found. labels May 24, 2026
@Soju06

Soju06 commented May 27, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Soju06 Soju06 merged commit 530c97f into Soju06:main May 27, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants