feat(DATAGO-126454): Add network dev broker for remote tool communication#131
Open
efunneko wants to merge 6 commits into
Open
feat(DATAGO-126454): Add network dev broker for remote tool communication#131efunneko wants to merge 6 commits into
efunneko wants to merge 6 commits into
Conversation
Add comprehensive tests for the network dev broker TCP protocol, server, and client covering protocol encoding/decoding, server lifecycle, message routing, wildcard subscriptions, and client connect/disconnect/reconnect behavior.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the purpose of this change?
Add TCP networking support to the dev broker, enabling remote tools and processes (e.g., Docker containers) to communicate with a running SAM instance over the network. This is needed to support remote tools that need to interact with SAM's message broker but are not running in the same process.
How was this change implemented?
New modules:
dev_broker_protocol.py— JSON-over-TCP protocol definitions (newline-delimited JSON) with command types, response statuses, and error codesdev_broker_server.py— Async TCP server exposing DevBroker functionality over the network, managing client sessions, subscriptions, and message queuesnetwork_dev_broker.py— Network-based DevBroker client implementing the Messaging interface as a drop-in replacement for the in-process DevBrokerModified modules:
dev_broker_messaging.py— Added network server support and message forwarding to network clientsmessaging_builder.py— Added support for creating network dev broker instancesbroker_base.py/broker_input.py— Updated to support the new messaging typeapp.py— Integration of dev broker server startupKey Design Decisions
How was this change tested?
Is there anything the reviewers should focus on?
NetworkDevBroker— ensure the retry/backoff behavior is appropriate_send_commandmethod (uses a threading lock)Jira: DATAGO-126454