Skip to content

DATAGO-98290: Update workflows #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmanRiat1 merged 8 commits into from
Apr 1, 2025
Merged

DATAGO-98290: Update workflows #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c042ce7
Update release.yml
AmanRiat1 Apr 1, 2025
f6a5594
Update build-java-binder.yaml
AmanRiat1 Apr 1, 2025
bdf5b2b
Update release.yml
AmanRiat1 Apr 1, 2025
d88b5ad
Update build-java-binder.yaml
AmanRiat1 Apr 1, 2025
ee83ad9
Update build.yaml
AmanRiat1 Apr 1, 2025
a9800f2
Update build.yaml
AmanRiat1 Apr 1, 2025
f60447c
Update build.yaml
AmanRiat1 Apr 1, 2025
5db34a3
Update build-java-binder.yaml
AmanRiat1 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/build-java-binder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ jobs:
statuses: write
checks: write
id-token: write
env:
VAULT_ADDR: https://vault.maas-vault-prod.solace.cloud:8200

steps:
- name: Checkout repo
uses: actions/checkout@v4
Expand All @@ -60,7 +59,7 @@ jobs:
uses: hashicorp/vault-action@v3
continue-on-error: true
with:
url: "https://vault.maas-vault-prod.solace.cloud:8200"
url: "${{ secrets.VAULT_ADDR }}"
role: "cicd-workflows-secret-read-role"
method: jwt
path: jwt-github
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ jobs:
uses: ./.github/workflows/build-java-binder.yaml
with:
unit_integration_test_reports: "**/target/failsafe-reports/**/TEST*.xml"
secrets: inherit

5 changes: 2 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ jobs:
contents: write
packages: write
id-token: write
env:
VAULT_ADDR: https://vault.maas-vault-prod.solace.cloud:8200

steps:
- uses: actions/checkout@v4
with:
Expand All @@ -57,7 +56,7 @@ jobs:
uses: hashicorp/vault-action@v3
continue-on-error: true
with:
url: "${{ env.VAULT_ADDR }}"
url: "${{ secrets.VAULT_ADDR }}"
role: "cicd-workflows-secret-read-role"
method: jwt
path: jwt-github
Expand Down
Loading