DATAGO-121329: Explicitly use vault token for reading SolaceDev packages#48
Merged
DATAGO-121329: Explicitly use vault token for reading SolaceDev packages#48
Conversation
Collaborator
AmanRiat1
commented
Jan 9, 2026
- The default github token does not have access to maven packages in SolaceDev as that is what was being used before
- Now we use the readonly token to get the maven packages in SolaceDev but use the default github workflow token to publish to github packages
… test release authentication workflow
|
|
||
| - name: Deploy Artifacts (GH Packages) | ||
| env: | ||
| PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }} |
There was a problem hiding this comment.
wondering can this token deploy to github packages (this looks readonly?) , or it is just for reading, and write is done using github_token?
Collaborator
Author
There was a problem hiding this comment.
Basically the packages token works for this in the settings.xml to get packages from SolaceDev
maven/settings.xml (lines 37-41):
<server>
<id>github-solacedev</id>
<username>${env.PACKAGES_READ_USER}</username>
<password>${env.PACKAGES_READ_TOKEN}</password>
</server>
This matches the repository definition at lines 20-31:
<repository>
<id>github-solacedev</id>
<url>https://maven.pkg.github.com/SolaceDev/*</url>
...
</repository>
When we publish we use this profile which use the github workflow token to publish the package:
maven/settings.xml (lines 42-46):
<server>
<id>github</id>
<username>${env.GITHUB_ACTOR}</username>
<password>${env.GITHUB_TOKEN}</password>
</server>
pom.xml (lines 641-647) - In the profile activated by -DreleaseTarget=github:
<distributionManagement>
<repository>
<id>github</id>
<name>GitHub SolaceProducts Maven Packages - Binder</name>
<url>https://maven.pkg.github.com/SolaceProducts/pubsubplus-connector-spark</url>
</repository>
</distributionManagement>
There was a problem hiding this comment.
Awesome, thanks for explanations @AmanRiat1
antonysavio-sol
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.