Skip to content

DATAGO-121329: Explicitly use vault token for reading SolaceDev packages#48

Merged
AmanRiat1 merged 4 commits intomasterfrom
DATAGO-121329
Jan 9, 2026
Merged

DATAGO-121329: Explicitly use vault token for reading SolaceDev packages#48
AmanRiat1 merged 4 commits intomasterfrom
DATAGO-121329

Conversation

@AmanRiat1
Copy link
Collaborator

  • The default github token does not have access to maven packages in SolaceDev as that is what was being used before
  • Now we use the readonly token to get the maven packages in SolaceDev but use the default github workflow token to publish to github packages


- name: Deploy Artifacts (GH Packages)
env:
PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering can this token deploy to github packages (this looks readonly?) , or it is just for reading, and write is done using github_token?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the packages token works for this in the settings.xml to get packages from SolaceDev

  maven/settings.xml (lines 37-41):
  <server>
      <id>github-solacedev</id>
      <username>${env.PACKAGES_READ_USER}</username>
      <password>${env.PACKAGES_READ_TOKEN}</password>
  </server>

  This matches the repository definition at lines 20-31:
  <repository>
      <id>github-solacedev</id>
      <url>https://maven.pkg.github.com/SolaceDev/*</url>
      ...
  </repository>

When we publish we use this profile which use the github workflow token to publish the package:

  maven/settings.xml (lines 42-46):
  <server>
      <id>github</id>
      <username>${env.GITHUB_ACTOR}</username>
      <password>${env.GITHUB_TOKEN}</password>
  </server>

  pom.xml (lines 641-647) - In the profile activated by -DreleaseTarget=github:
  <distributionManagement>
      <repository>
          <id>github</id>
          <name>GitHub SolaceProducts Maven Packages - Binder</name>
          <url>https://maven.pkg.github.com/SolaceProducts/pubsubplus-connector-spark</url>
      </repository>
  </distributionManagement>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for explanations @AmanRiat1

@AmanRiat1 AmanRiat1 merged commit a2e36be into master Jan 9, 2026
3 of 5 checks passed
@AmanRiat1 AmanRiat1 deleted the DATAGO-121329 branch January 9, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants