Skip to content

Conversation

@karlderkaefer
Copy link

this change gives the user the option to overwrite values for probes for example

helm template . --set probes.readiness.timeout=5s -s templates/solaceStatefulSet.yaml | grep -A 6 "readinessProbe:"
        readinessProbe:
          exec:
            command:
            - /mnt/disks/solace/readiness_check.sh
          initialDelaySeconds: 30
          periodSeconds: 5
          timeout: 5s

closes #137

@karlderkaefer
Copy link
Author

@bczoma could you take a look?

@bczoma
Copy link
Collaborator

bczoma commented Mar 1, 2024

@karlderkaefer thanks for the proposal. Solace is adding this to the list of upcoming features and will include it in a release, together with documentation.

@zbialik
Copy link

zbialik commented Apr 30, 2025

FWIW I think this might also want to account for the timeout associated with the curl request that the readiness_check.sh relies on -- see here:

health_result=`curl -s -o /dev/null -w "%{http_code}" http://localhost:5550/health-check/guaranteed-active`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Readiness Probe configurable

3 participants